Animations: Reduce flakiness of transitions/cancel-and-start-new.html

Animations: Reduce flakiness of transitions/cancel-and-start-new.html

cancel-and-start-new.html was relying on very precise timing.

BUG=521855
Committed: https://crrev.com/500af7327e69c25b5d5c0cda2d1bd97d86996e1d
Cr-Commit-Position: refs/heads/master@{#406519}

[Eric Willigers, 2016-06-29 06:08:14]

ericwilligers@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2016-06-30 04:36:20]

https://codereview.chromium.org/2108093002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html
(right):

https://codereview.chromium.org/2108093002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html:61:
setTimeout(cancelTransition, 100);
Use internals.pauseAnimations() instead of setTimeout().

[Eric Willigers, 2016-07-01 03:15:46]

https://codereview.chromium.org/2108093002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html
(right):

https://codereview.chromium.org/2108093002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html:61:
setTimeout(cancelTransition, 100);
On 2016/06/30 at 04:36:20, alancutter wrote:
> Use internals.pauseAnimations() instead of setTimeout().

Done

[alancutter (OOO until 2018), 2016-07-01 03:29:41]

On 2016/07/01 at 03:15:46, ericwilligers wrote:
>
https://codereview.chromium.org/2108093002/diff/1/third_party/WebKit/LayoutTe...
> File third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html
(right):
> 
>
https://codereview.chromium.org/2108093002/diff/1/third_party/WebKit/LayoutTe...
> third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html:61:
setTimeout(cancelTransition, 100);
> On 2016/06/30 at 04:36:20, alancutter wrote:
> > Use internals.pauseAnimations() instead of setTimeout().
> 
> Done

We should check that the transitions are starting/stopping before the final
check now that we're doing this synchronously.

[Eric Willigers, 2016-07-11 05:01:14]

On 2016/07/01 at 03:29:41, alancutter wrote:
> On 2016/07/01 at 03:15:46, ericwilligers wrote:
> >
https://codereview.chromium.org/2108093002/diff/1/third_party/WebKit/LayoutTe...
> > File third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html
(right):
> > 
> >
https://codereview.chromium.org/2108093002/diff/1/third_party/WebKit/LayoutTe...
> > third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html:61:
setTimeout(cancelTransition, 100);
> > On 2016/06/30 at 04:36:20, alancutter wrote:
> > > Use internals.pauseAnimations() instead of setTimeout().
> > 
> > Done
> 
> We should check that the transitions are starting/stopping before the final
check now that we're doing this synchronously.

Done

[alancutter (OOO until 2018), 2016-07-20 06:14:59]

lgtm.

This test should be converted into a testharness.js test and there's really no
need for it to be split up into functions the way it currently is. Problems we
can resolve in a separate patch.

[Eric Willigers, 2016-07-20 07:31:20]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-07-20 07:31:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 08:43:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-20 08:43:29]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 08:46:34]

Description was changed from

==========
Animations: Reduce flakiness of transitions/cancel-and-start-new.html

cancel-and-start-new.html was relying on very precise timing.

BUG=521855
==========

to

==========
Animations: Reduce flakiness of transitions/cancel-and-start-new.html

cancel-and-start-new.html was relying on very precise timing.

BUG=521855

Committed: https://crrev.com/500af7327e69c25b5d5c0cda2d1bd97d86996e1d
Cr-Commit-Position: refs/heads/master@{#406519}
==========

[commit-bot: I haz the power, 2016-07-20 08:46:35]

Patchset 3 (id:??) landed as
https://crrev.com/500af7327e69c25b5d5c0cda2d1bd97d86996e1d
Cr-Commit-Position: refs/heads/master@{#406519}