Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2108093002: Animations: Reduce flakiness of transitions/cancel-and-start-new.html (Closed)

Created:
4 years, 5 months ago by Eric Willigers
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Animations: Reduce flakiness of transitions/cancel-and-start-new.html cancel-and-start-new.html was relying on very precise timing. BUG=521855 Committed: https://crrev.com/500af7327e69c25b5d5c0cda2d1bd97d86996e1d Cr-Commit-Position: refs/heads/master@{#406519}

Patch Set 1 #

Total comments: 2

Patch Set 2 : internals.pauseAnimations #

Patch Set 3 : checks transitions start and stop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -22 lines) Patch
M third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html View 1 2 3 chunks +46 lines, -22 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Eric Willigers
4 years, 5 months ago (2016-06-29 06:08:15 UTC) #2
alancutter (OOO until 2018)
https://codereview.chromium.org/2108093002/diff/1/third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html File third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html (right): https://codereview.chromium.org/2108093002/diff/1/third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html#newcode61 third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html:61: setTimeout(cancelTransition, 100); Use internals.pauseAnimations() instead of setTimeout().
4 years, 5 months ago (2016-06-30 04:36:20 UTC) #3
Eric Willigers
https://codereview.chromium.org/2108093002/diff/1/third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html File third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html (right): https://codereview.chromium.org/2108093002/diff/1/third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html#newcode61 third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html:61: setTimeout(cancelTransition, 100); On 2016/06/30 at 04:36:20, alancutter wrote: > ...
4 years, 5 months ago (2016-07-01 03:15:46 UTC) #4
alancutter (OOO until 2018)
On 2016/07/01 at 03:15:46, ericwilligers wrote: > https://codereview.chromium.org/2108093002/diff/1/third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html > File third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html (right): > > https://codereview.chromium.org/2108093002/diff/1/third_party/WebKit/LayoutTests/transitions/cancel-and-start-new.html#newcode61 ...
4 years, 5 months ago (2016-07-01 03:29:41 UTC) #5
Eric Willigers
On 2016/07/01 at 03:29:41, alancutter wrote: > On 2016/07/01 at 03:15:46, ericwilligers wrote: > > ...
4 years, 5 months ago (2016-07-11 05:01:14 UTC) #6
alancutter (OOO until 2018)
lgtm. This test should be converted into a testharness.js test and there's really no need ...
4 years, 5 months ago (2016-07-20 06:14:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108093002/40001
4 years, 5 months ago (2016-07-20 07:31:40 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-20 08:43:24 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 08:43:29 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 08:46:35 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/500af7327e69c25b5d5c0cda2d1bd97d86996e1d
Cr-Commit-Position: refs/heads/master@{#406519}

Powered by Google App Engine
This is Rietveld 408576698