components/translate/core/browser/resources/translate.js - Issue 2108053004: add code to propagate finch config TranslateServerStudy server_params to translate element code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/resources/translate.js

Issue 2108053004: add code to propagate finch config TranslateServerStudy server_params to translate element code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove header changes and unnessary initialization Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/translate/translate_script_browsertest.cc ('k') | components/translate/core/browser/translate_script.cc » ('j') | components/translate/core/browser/translate_script.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/core/browser/resources/translate.js

diff --git a/components/translate/core/browser/resources/translate.js b/components/translate/core/browser/resources/translate.js

index fb59e6601b97f3558e04db5dab758d9b98149dec..79c579342531c9bce86a66ca16d3e7a6db98738c 100644

--- a/components/translate/core/browser/resources/translate.js

+++ b/components/translate/core/browser/resources/translate.js

@@ -258,12 +258,15 @@ cr.googleTranslate = (function() {

lib = google.translate.TranslateService({

// translateApiKey is predefined by translate_script.cc.

'key': translateApiKey,

+ 'serverParams': serverParams,

'useSecureConnection': true

});

translateApiKey = undefined;

+ serverParams = undefined;

} catch (err) {

errorCode = ERROR['INITIALIZATION_ERROR'];

translateApiKey = undefined;

+ serverParams = undefined;

return;

}

// The TranslateService is not available immediately as it needs to start