components/translate/core/browser/translate_script.h - Issue 2108053004: add code to propagate finch config TranslateServerStudy server_params to translate element code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/translate_script.h

Issue 2108053004: add code to propagate finch config TranslateServerStudy server_params to translate element code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix browser_tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/translate/core/browser/resources/translate.js ('k') | components/translate/core/browser/translate_script.cc » ('j') | components/translate/core/browser/translate_script.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/core/browser/translate_script.h

diff --git a/components/translate/core/browser/translate_script.h b/components/translate/core/browser/translate_script.h

index 8c358735035d2328a38e4b79778078fd7fcff449..822138c5232932e8da6b5a3f39e7f9a88ee4512a 100644

--- a/components/translate/core/browser/translate_script.h

+++ b/components/translate/core/browser/translate_script.h

@@ -26,6 +26,12 @@ class TranslateScript {

static const int kFetcherId = 0;

+ // Study name in finch config file for the server params.

+ static const char kTranslateServerStudy[];

groby-ooo-7-16 2016/08/02 21:14:10 Please don't expose in the header - I think we can

ftang 2016/08/02 23:46:23 Done.

+ // Param name in finch config file for the server params.

+ static const char kServerParams[];

TranslateScript();

virtual ~TranslateScript();