Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2108043003: Move LayoutMenuList's height calculation logic to styleDidChange method. (Closed)

Created:
4 years, 5 months ago by Gleb Lanbin
Modified:
4 years, 5 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move LayoutMenuList's height calculation logic to styleDidChange method as we need to recalculate the height if the page zoom is changed. BUG=624269 TEST=LayoutTests/transforms/2d/zoom-menulist.html Committed: https://crrev.com/d0ff92817fb5c8b1112393b46318b3691c53b809 Cr-Commit-Position: refs/heads/master@{#403248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/transforms/2d/zoom-menulist.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMenuList.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMenuList.cpp View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Gleb Lanbin
4 years, 5 months ago (2016-06-30 16:05:02 UTC) #5
eae
Nice! LGTM
4 years, 5 months ago (2016-06-30 17:56:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108043003/60001
4 years, 5 months ago (2016-06-30 17:57:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/29587)
4 years, 5 months ago (2016-06-30 18:02:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108043003/60001
4 years, 5 months ago (2016-06-30 18:47:10 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 5 months ago (2016-06-30 19:27:59 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 19:28:11 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 19:29:55 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0ff92817fb5c8b1112393b46318b3691c53b809
Cr-Commit-Position: refs/heads/master@{#403248}

Powered by Google App Engine
This is Rietveld 408576698