Cancel image loads if decoding failed.

third_party/WebKit/Source/platform/graphics/BitmapImage.cpp

 /*
  * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 180 matching lines @@
 
 bool BitmapImage::setData(PassRefPtr<SharedBuffer> data, bool allDataReceived)
 {
     if (!data.get())
         return true;
 
     int length = data->size();
     if (!length)
         return true;
 
-    m_source.setData(*data, allDataReceived);
+    // If setData() returns InvalidData, we know that this is a decode error.

[pdr., 2016/07/21 04:39:06]

Nit: "If ImageSource::setData returns Invalid, we know that this is a decode
error."

[Nate Chapin, 2016/07/21 20:59:05]

Done.

+    // Report size available so that it gets registered as such in
+    // ImageResource.
+    if (m_source.setData(*data, allDataReceived) == ImageDecoder::SniffResult::Invalid)
+        return true;
 
     return dataChanged(allDataReceived);

[pdr., 2016/07/21 04:39:06]

Not your fault, but would you mind changing the return value of this function
and dataChanged to be an enum too? Maybe just:
enum class ImageSizeAvailable {
    SizeAvailable,
    SizeUnavailable
}

[Nate Chapin, 2016/07/21 20:59:05]

Went with 'enum SizeAvailability' inside the Image namespace, instead of 'enum
class ImageSizeAvailable', because it looked more readable and less redundant to
me. Any objections?

 }
 
 bool BitmapImage::dataChanged(bool allDataReceived)
 {
     TRACE_EVENT0("blink", "BitmapImage::dataChanged");
 
     // Clear all partially-decoded frames. For most image formats, there is only
     // one frame, but at least GIF and ICO can have more. With GIFs, the frames
     // come in order and we ask to decode them in order, waiting to request a
     // subsequent frame until the prior one is complete. Given that we clear
@@ skipping 393 matching lines @@
 
     // We need to draw this frame if we advanced to it while not skipping, or if
     // while trying to skip frames we hit the last frame and thus had to stop.
     if (skippingFrames != advancedAnimation)
         getImageObserver()->animationAdvanced(this);
 
     return advancedAnimation;
 }
 
 } // namespace blink