EME: Clear Key CDM now generates keystatuseschange event on close()

media/cdm/aes_decryptor.cc

Index: media/cdm/aes_decryptor.cc
diff --git a/media/cdm/aes_decryptor.cc b/media/cdm/aes_decryptor.cc
index af7182f1097ab3fdbaeebe8180c97bb95d690802..f01fe8b10593645d130095d8ae55757083b7510d 100644
--- a/media/cdm/aes_decryptor.cc
+++ b/media/cdm/aes_decryptor.cc
@@ -411,6 +411,13 @@ void AesDecryptor::CloseSession(const std::string& session_id,
   // Close the session.
   DeleteKeysForSession(session_id);
   promise->resolve();

[ddorwin, 2016/06/30 06:51:24]

This is supposed to be last.
https://w3c.github.io/encrypted-media/#session-closed

Also, everything here and below is supposed to be run in a task to ensure it
happens in the correct order. That's probably a larger issue, though.

For now, move the resolve to the end.

[jrummell, 2016/07/01 00:01:22]

Agreed. However, since we're not currently using a task, calling the cb's after
resolving the promise is the way it's been done in this file before (see
UpdateSession() directly above).

This could be converted to call PostTask (plus the other calls above). WDYT?

+
+  // Update key statuses. All keys are gone, so it's an empty set.

[ddorwin, 2016/06/30 06:51:24]

nit: "gone" sounds informal. I suggest either copy the spec line or say all keys
have been destroyed, so ...

[jrummell, 2016/07/01 00:01:22]

Done.

+  session_keys_change_cb_.Run(session_id, false, CdmKeysInfo());
+
+  // Update expiration time to NaN. (http://crbug.com/624192)
+
+  // Resolve the closed attribute.
   session_closed_cb_.Run(session_id);
 }