Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1670)

Unified Diff: chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc

Issue 210803003: [fsp] Decouple file_service_provider::Service. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
diff --git a/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc b/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
index 471f7c3d0c0b8d03bc6d5358080adfc9d938bb25..e9654d2b701f6fff9d7443c9d2b80fa357816ff0 100644
--- a/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
+++ b/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
@@ -119,7 +119,6 @@ bool FileSystemProviderMountFunction::RunImpl() {
// Don't append an error on success.
SetResult(result);
- SendResponse(true);
return true;
}
@@ -142,7 +141,6 @@ bool FileSystemProviderUnmountFunction::RunImpl() {
base::ListValue* result = new base::ListValue();
SetResult(result);
- SendResponse(true);
return true;
}
@@ -155,11 +153,12 @@ bool FileSystemProviderInternalUnmountRequestedSuccessFunction::RunImpl() {
chromeos::file_system_provider::Service::Get(GetProfile());
DCHECK(service);
- if (!service->FulfillRequest(extension_id(),
- params->file_system_id,
- params->request_id,
- scoped_ptr<base::DictionaryValue>(),
- false /* has_more */)) {
+ if (!service->request_manager()->FulfillRequest(
+ extension_id(),
+ params->file_system_id,
+ params->request_id,
+ scoped_ptr<base::DictionaryValue>(),
+ false /* has_more */)) {
// TODO(mtomasz): Pass more detailed errors, rather than just a bool.
base::ListValue* result = new base::ListValue();
result->Append(
@@ -170,7 +169,6 @@ bool FileSystemProviderInternalUnmountRequestedSuccessFunction::RunImpl() {
base::ListValue* result = new base::ListValue();
SetResult(result);
- SendResponse(true);
return true;
}
@@ -183,11 +181,11 @@ bool FileSystemProviderInternalUnmountRequestedErrorFunction::RunImpl() {
chromeos::file_system_provider::Service::Get(GetProfile());
DCHECK(service);
- if (!service->RejectRequest(extension_id(),
- params->file_system_id,
- params->request_id,
- ProviderErrorToFileError(params->error))) {
- // TODO(mtomasz): Pass more detailed errors, rather than just a bool.
+ if (!service->request_manager()->RejectRequest(
+ extension_id(),
+ params->file_system_id,
+ params->request_id,
+ ProviderErrorToFileError(params->error))) {
base::ListValue* result = new base::ListValue();
result->Append(
CreateError(kSecurityErrorName, kResponseFailedErrorMessage));
@@ -197,7 +195,6 @@ bool FileSystemProviderInternalUnmountRequestedErrorFunction::RunImpl() {
base::ListValue* result = new base::ListValue();
SetResult(result);
- SendResponse(true);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698