Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1246)

Unified Diff: chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc

Issue 210803003: [fsp] Decouple file_service_provider::Service. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed more comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
diff --git a/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc b/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
index 93df5ed470b73b627430642f9a04378c13ebd4c3..4b2be500ba32c5571e7673f6b15b5528ec46b759 100644
--- a/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
+++ b/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
@@ -155,11 +155,12 @@ bool FileSystemProviderInternalUnmountRequestedSuccessFunction::RunImpl() {
chromeos::file_system_provider::Service::Get(GetProfile());
DCHECK(service);
- if (!service->FulfillRequest(extension_id(),
- params->file_system_id,
- params->request_id,
- scoped_ptr<base::DictionaryValue>(),
- false /* has_more */)) {
+ if (!service->request_manager()->FulfillRequest(
+ extension_id(),
+ params->file_system_id,
+ params->request_id,
+ scoped_ptr<base::DictionaryValue>(),
+ false /* has_more */)) {
// TODO(mtomasz): Pass more detailed errors, rather than just a bool.
base::ListValue* result = new base::ListValue();
result->Append(
@@ -191,10 +192,11 @@ bool FileSystemProviderInternalUnmountRequestedErrorFunction::RunImpl() {
const api::file_system_provider::ProviderError provider_error =
api::file_system_provider::ParseProviderError(params->error);
- if (!service->RejectRequest(extension_id(),
- params->file_system_id,
- params->request_id,
- ProviderErrorToFileError(provider_error))) {
+ if (!service->request_manager()->RejectRequest(
+ extension_id(),
+ params->file_system_id,
+ params->request_id,
+ ProviderErrorToFileError(provider_error))) {
// TODO(mtomasz): Pass more detailed errors, rather than just a bool.
base::ListValue* result = new base::ListValue();
result->Append(

Powered by Google App Engine
This is Rietveld 408576698