Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc

Issue 210803003: [fsp] Decouple file_service_provider::Service. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed more comments. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include <string>
6 #include <vector>
7
8 #include "base/files/file.h"
9 #include "base/memory/scoped_ptr.h"
10 #include "base/values.h"
11 #include "chrome/browser/chromeos/file_system_provider/provided_file_system.h"
12 #include "chrome/browser/chromeos/file_system_provider/provided_file_system_info .h"
13 #include "chrome/browser/chromeos/file_system_provider/provided_file_system_inte rface.h"
14 #include "chrome/browser/chromeos/file_system_provider/request_manager.h"
15 #include "chrome/test/base/testing_profile.h"
16 #include "content/public/test/test_browser_thread_bundle.h"
17 #include "extensions/browser/event_router.h"
18 #include "testing/gtest/include/gtest/gtest.h"
19
20 namespace chromeos {
21 namespace file_system_provider {
22
23 namespace {
24
25 const char kExtensionId[] = "mbflcebpggnecokmikipoihdbecnjfoj";
26 const int kExpectedRequestId = 1;
27 const int kFileSystemId = 2;
28 const char kFileSystemName[] = "Camera Pictures";
29 const base::FilePath::CharType kMountPath[] = FILE_PATH_LITERAL(
30 "/provided/mbflcebpggnecokmikipoihdbecnjfoj-1-testing_profile-hash");
31
32 class FakeEventRouter : public extensions::EventRouter {
33 public:
34 explicit FakeEventRouter(Profile* profile) : EventRouter(profile, NULL) {}
35 virtual ~FakeEventRouter() {}
36
37 virtual void DispatchEventToExtension(const std::string& extension_id,
38 scoped_ptr<extensions::Event> event)
39 OVERRIDE {
40 extension_id_ = extension_id;
41 event_ = event.Pass();
42 }
43
44 const std::string& extension_id() const { return extension_id_; }
45
46 const extensions::Event* event() const { return event_.get(); }
47
48 private:
49 std::string extension_id_;
50 scoped_ptr<extensions::Event> event_;
51
52 DISALLOW_COPY_AND_ASSIGN(FakeEventRouter);
53 };
54
55 class EventLogger {
56 public:
57 EventLogger() : weak_ptr_factory_(this) {}
58 virtual ~EventLogger() {}
59
60 void OnStatusCallback(base::File::Error error) {
61 error_.reset(new base::File::Error(error));
62 }
63
64 base::File::Error* error() { return error_.get(); }
65
66 base::WeakPtr<EventLogger> GetWeakPtr() {
67 return weak_ptr_factory_.GetWeakPtr();
68 }
69
70 private:
71 scoped_ptr<base::File::Error> error_;
72
73 base::WeakPtrFactory<EventLogger> weak_ptr_factory_;
74 DISALLOW_COPY_AND_ASSIGN(EventLogger);
75 };
76
77 } // namespace
78
79 class FileSystemProviderProvidedFileSystemTest : public testing::Test {
80 protected:
81 FileSystemProviderProvidedFileSystemTest() {}
82 virtual ~FileSystemProviderProvidedFileSystemTest() {}
83
84 virtual void SetUp() OVERRIDE {
85 profile_.reset(new TestingProfile);
86 event_router_.reset(new FakeEventRouter(profile_.get()));
87 request_manager_.reset(new RequestManager());
88 file_system_info_.reset(
89 new ProvidedFileSystemInfo(kExtensionId,
90 kFileSystemId,
91 kFileSystemName,
92 base::FilePath(kMountPath)));
93 provided_file_system_.reset(new ProvidedFileSystem(
94 event_router_.get(), request_manager_.get(), *file_system_info_.get()));
95 }
96
97 content::TestBrowserThreadBundle thread_bundle_;
98 scoped_ptr<TestingProfile> profile_;
99 scoped_ptr<FakeEventRouter> event_router_;
100 scoped_ptr<RequestManager> request_manager_;
101 scoped_ptr<ProvidedFileSystemInfo> file_system_info_;
102 scoped_ptr<ProvidedFileSystemInterface> provided_file_system_;
103 };
104
105 TEST_F(FileSystemProviderProvidedFileSystemTest, RequestUnmount_Success) {
106 EventLogger logger;
107
108 bool result = provided_file_system_->RequestUnmount(
109 base::Bind(&EventLogger::OnStatusCallback, logger.GetWeakPtr()));
110 ASSERT_TRUE(result);
111
112 // Verify that the event has been sent to the providing extension.
113 EXPECT_EQ(kExtensionId, event_router_->extension_id());
114 const extensions::Event* event = event_router_->event();
115 ASSERT_TRUE(event);
116 ASSERT_TRUE(event->event_args);
117 base::ListValue* event_args = event->event_args.get();
118 EXPECT_EQ(2u, event_args->GetSize());
119 int file_system_id = 0;
120 EXPECT_TRUE(event_args->GetInteger(0, &file_system_id));
121 EXPECT_EQ(kFileSystemId, file_system_id);
122
123 // Remember the request id, and verify it is valid.
124 int request_id = 0;
125 EXPECT_TRUE(event_args->GetInteger(kExpectedRequestId, &request_id));
hashimoto 2014/03/26 06:53:04 1 instead of kExpectedRequestId?
mtomasz 2014/03/26 08:47:31 Woops! Done.
126 EXPECT_EQ(kExpectedRequestId, request_id);
127
128 // Callback should not be called, yet.
129 EXPECT_FALSE(logger.error());
130
131 // Simulate sending a success response from the providing extension.
132 scoped_ptr<base::DictionaryValue> response(new base::DictionaryValue());
133 bool reply_result = request_manager_->FulfillRequest(kExtensionId,
134 kFileSystemId,
135 request_id,
136 response.Pass(),
137 false /* has_next */);
138 ASSERT_TRUE(reply_result);
hashimoto 2014/03/26 06:53:04 nit: I guess this can be EXPECT.
mtomasz 2014/03/26 08:47:31 Done.
139
140 // Callback should be called. Verify the error code.
141 ASSERT_TRUE(logger.error());
142 EXPECT_EQ(base::File::FILE_OK, *logger.error());
143 }
144
145 TEST_F(FileSystemProviderProvidedFileSystemTest, RequestUnmount_Error) {
146 EventLogger logger;
147
148 bool result = provided_file_system_->RequestUnmount(
149 base::Bind(&EventLogger::OnStatusCallback, logger.GetWeakPtr()));
150 ASSERT_TRUE(result);
151
152 // Verify that the event has been sent to the providing extension.
153 EXPECT_EQ(kExtensionId, event_router_->extension_id());
154 const extensions::Event* event = event_router_->event();
155 ASSERT_TRUE(event);
156 ASSERT_TRUE(event->event_args);
157 base::ListValue* event_args = event->event_args.get();
158 EXPECT_EQ(2u, event_args->GetSize());
159 int file_system_id = 0;
160 EXPECT_TRUE(event_args->GetInteger(0, &file_system_id));
161 EXPECT_EQ(kFileSystemId, file_system_id);
162
163 // Remember the request id, and verify it is valid.
164 int request_id = 0;
165 EXPECT_TRUE(event_args->GetInteger(1, &request_id));
166 EXPECT_EQ(kExpectedRequestId, request_id);
167
168 // Simulate sending an error response from the providing extension.
169 scoped_ptr<base::DictionaryValue> response(new base::DictionaryValue());
170 bool reply_result =
171 request_manager_->RejectRequest(kExtensionId,
172 kFileSystemId,
173 request_id,
174 base::File::FILE_ERROR_NOT_FOUND);
175 ASSERT_TRUE(reply_result);
hashimoto 2014/03/26 06:53:04 ditto.
mtomasz 2014/03/26 08:47:31 Done.
176
177 // Callback should be called. Verify the error code.
178 ASSERT_TRUE(logger.error());
179 EXPECT_EQ(base::File::FILE_ERROR_NOT_FOUND, *logger.error());
180 }
181
182 } // namespace file_system_provider
183 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698