[fsp] Decouple file_service_provider::Service.

chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h"
 
 #include <string>
 
 #include "base/values.h"
 #include "chrome/browser/chromeos/file_system_provider/service.h"
@@ skipping 137 matching lines @@
 
 bool FileSystemProviderInternalUnmountRequestedSuccessFunction::RunImpl() {
   using api::file_system_provider_internal::UnmountRequestedSuccess::Params;
   const scoped_ptr<Params> params(Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params);
 
   chromeos::file_system_provider::Service* service =
       chromeos::file_system_provider::Service::Get(GetProfile());
   DCHECK(service);
 
-  if (!service->FulfillRequest(extension_id(),
-                               params->file_system_id,
-                               params->request_id,
-                               scoped_ptr<base::DictionaryValue>(),
-                               false /* has_more */)) {
+  if (!service->request_manager()->FulfillRequest(
+          extension_id(),
+          params->file_system_id,
+          params->request_id,
+          scoped_ptr<base::DictionaryValue>(),
+          false /* has_more */)) {
     // TODO(mtomasz): Pass more detailed errors, rather than just a bool.
     base::ListValue* result = new base::ListValue();
     result->Append(
         CreateError(kSecurityErrorName, kResponseFailedErrorMessage));
     SetResult(result);
     return false;
   }
 
   base::ListValue* result = new base::ListValue();
   SetResult(result);
   SendResponse(true);

[hashimoto, 2014/03/26 06:53:04]

nit: Just returning false isn't enough?

[mtomasz, 2014/03/26 08:47:31]

If we return false, then we would signal an error. However, this is not an
error, we want to finish with a success.

[hashimoto, 2014/03/26 09:04:26]

oops, I was confusing this with a SyncExtensionFunction's behavior to return the
result without manually calling SendResponse().

BTW, why all these functions are implemented as async functions?
It seems all of them can be sync functions. (=SyncExtensionFunction or
ChromeSyncExtensionFunction)

[mtomasz, 2014/03/26 10:53:58]

Good catch. Converted to SyncExtensionFunctions! Done.

   return true;
 }
 
 bool FileSystemProviderInternalUnmountRequestedErrorFunction::RunImpl() {
   using api::file_system_provider_internal::UnmountRequestedError::Params;
   const scoped_ptr<Params> params(Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params);
 
   chromeos::file_system_provider::Service* service =
       chromeos::file_system_provider::Service::Get(GetProfile());
   DCHECK(service);
 
   // Currently it is not possible to refer to types/enums defined in a different
   // IDL file. Therefore we need to convert DOMString to ProviderError, since
   // UnmountRequestedErrorFunction() is defined in a different namespace than
   // ProvidedError.
   // TODO(mtomasz): Remove this trick, once IDL supports namespaces correctly.
   const api::file_system_provider::ProviderError provider_error =
       api::file_system_provider::ParseProviderError(params->error);
 
-  if (!service->RejectRequest(extension_id(),
-                              params->file_system_id,
-                              params->request_id,
-                              ProviderErrorToFileError(provider_error))) {
+  if (!service->request_manager()->RejectRequest(
+          extension_id(),
+          params->file_system_id,
+          params->request_id,
+          ProviderErrorToFileError(provider_error))) {
     // TODO(mtomasz): Pass more detailed errors, rather than just a bool.
     base::ListValue* result = new base::ListValue();
     result->Append(
         CreateError(kSecurityErrorName, kResponseFailedErrorMessage));
     SetResult(result);
     return false;
   }
 
   base::ListValue* result = new base::ListValue();
   SetResult(result);
   SendResponse(true);
   return true;
 }
 
 }  // namespace extensions