[fsp] Decouple file_service_provider::Service.

chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <string>
+#include <vector>
+
+#include "base/files/file.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/values.h"
+#include "chrome/browser/chromeos/file_system_provider/provided_file_system.h"
+#include "chrome/browser/chromeos/file_system_provider/provided_file_system_info.h"
+#include "chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h"
+#include "chrome/browser/chromeos/file_system_provider/request_manager.h"
+#include "chrome/test/base/testing_profile.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "extensions/browser/event_router.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace chromeos {
+namespace file_system_provider {
+
+namespace {
+
+static const std::string kExtensionId = "mbflcebpggnecokmikipoihdbecnjfoj";

[hashimoto, 2014/03/26 03:03:01]

nit: "static" is not needed.
nit: use char[]

[mtomasz, 2014/03/26 05:45:13]

Done.

+static const int kFileSystemId = 1;
+static const std::string kFileSystemName = "Camera Pictures";
+static const base::FilePath::CharType kMountPath[] = FILE_PATH_LITERAL(
+    "/provided/mbflcebpggnecokmikipoihdbecnjfoj-1-testing_profile-hash");
+
+class FakeEventRouter : public extensions::EventRouter {
+ public:
+  explicit FakeEventRouter(Profile* profile) : EventRouter(profile, NULL) {}
+  virtual ~FakeEventRouter() {}
+
+  virtual void DispatchEventToExtension(const std::string& extension_id,
+                                        scoped_ptr<extensions::Event> event)
+      OVERRIDE {
+    extension_id_ = extension_id;
+    event_ = event.Pass();
+  }
+
+  std::string extension_id() const { return extension_id_; }

[hashimoto, 2014/03/26 03:03:01]

nit: const std::string&?

[mtomasz, 2014/03/26 05:45:13]

Done.

+
+  const extensions::Event* event() const { return event_.get(); }
+
+ private:
+  std::string extension_id_;
+  scoped_ptr<extensions::Event> event_;
+
+  DISALLOW_COPY_AND_ASSIGN(FakeEventRouter);
+};
+
+class EventLogger {
+ public:
+  EventLogger() : weak_ptr_factory_(this) {}
+  virtual ~EventLogger() {}
+
+  void OnStatusCallback(base::File::Error error) {
+    error_.reset(new base::File::Error(error));
+  }
+
+  base::File::Error* error() { return error_.get(); }
+
+  base::WeakPtr<EventLogger> GetWeakPtr() {
+    return weak_ptr_factory_.GetWeakPtr();
+  }
+
+ private:
+  scoped_ptr<base::File::Error> error_;
+
+  base::WeakPtrFactory<EventLogger> weak_ptr_factory_;
+  DISALLOW_COPY_AND_ASSIGN(EventLogger);
+};
+
+}  // namespace
+
+class FileSystemProviderProvidedFileSystemTest : public testing::Test {
+ protected:
+  FileSystemProviderProvidedFileSystemTest() {}
+  virtual ~FileSystemProviderProvidedFileSystemTest() {}
+
+  virtual void SetUp() OVERRIDE {
+    profile_.reset(new TestingProfile);
+    event_router_.reset(new FakeEventRouter(profile_.get()));
+    request_manager_.reset(new RequestManager());
+    file_system_info_.reset(
+        new ProvidedFileSystemInfo(kExtensionId,
+                                   kFileSystemId,
+                                   kFileSystemName,
+                                   base::FilePath(kMountPath)));
+    provided_file_system_.reset(new ProvidedFileSystem(
+        event_router_.get(), request_manager_.get(), *file_system_info_.get()));
+  }
+
+  content::TestBrowserThreadBundle thread_bundle_;
+  scoped_ptr<TestingProfile> profile_;
+  scoped_ptr<FakeEventRouter> event_router_;
+  scoped_ptr<RequestManager> request_manager_;
+  scoped_ptr<ProvidedFileSystemInfo> file_system_info_;
+  scoped_ptr<ProvidedFileSystemInterface> provided_file_system_;
+};
+
+TEST_F(FileSystemProviderProvidedFileSystemTest, RequestUnmount_Success) {
+  EventLogger logger;
+
+  bool result = provided_file_system_->RequestUnmount(
+      base::Bind(&EventLogger::OnStatusCallback, logger.GetWeakPtr()));
+  ASSERT_TRUE(result);
+
+  // Verify that the event has been sent to the providing extension.
+  EXPECT_EQ(kExtensionId, event_router_->extension_id());
+  const extensions::Event* event = event_router_->event();
+  ASSERT_TRUE(event);
+  ASSERT_TRUE(event->event_args);
+  base::ListValue* event_args = event->event_args.get();
+  ASSERT_EQ(2u, event_args->GetSize());

[hashimoto, 2014/03/26 03:03:01]

nit: EXPECT instead of ASSERT?

[mtomasz, 2014/03/26 05:45:13]

Good point. Done.

+  int file_system_id;
+  event_args->GetInteger(0, &file_system_id);

[hashimoto, 2014/03/26 03:03:01]

EXPECT_TRUE?

[mtomasz, 2014/03/26 05:45:13]

Done.

+  EXPECT_EQ(kFileSystemId, file_system_id);
+
+  // Remember the request id, and verify it is valid.
+  int request_id;

[hashimoto, 2014/03/26 03:03:01]

nit: Please don't leave this variable uninitialized.

[mtomasz, 2014/03/26 05:45:13]

Done.

+  event_args->GetInteger(0, &request_id);

[hashimoto, 2014/03/26 03:03:01]

Why are you calling GetInteger for the index=0 twice?

[mtomasz, 2014/03/26 05:45:13]

Should be index=1 for the second one. Coincidentally, value for both was same. I
just changed kFilesystemId to a different value that request_id. Done.

+  EXPECT_LT(0, request_id);
+
+  // Callback should not be called, yet.
+  EXPECT_FALSE(logger.error());
+
+  // Simulate sending a success response from the providing extension.
+  scoped_ptr<base::DictionaryValue> response(new base::DictionaryValue());
+  bool reply_result = request_manager_->FulfillRequest(kExtensionId,
+                                                       kFileSystemId,
+                                                       request_id,
+                                                       response.Pass(),
+                                                       false /* has_next */);
+  ASSERT_TRUE(reply_result);
+
+  // Callback should be called. Verify the error code.
+  ASSERT_TRUE(logger.error());
+  EXPECT_EQ(base::File::FILE_OK, *logger.error());
+}
+
+TEST_F(FileSystemProviderProvidedFileSystemTest, RequestUnmount_Error) {
+  EventLogger logger;
+
+  bool result = provided_file_system_->RequestUnmount(
+      base::Bind(&EventLogger::OnStatusCallback, logger.GetWeakPtr()));
+  ASSERT_TRUE(result);
+
+  // Verify that the event has been sent to the providing extension.
+  EXPECT_EQ(kExtensionId, event_router_->extension_id());
+  const extensions::Event* event = event_router_->event();
+  ASSERT_TRUE(event);
+  ASSERT_TRUE(event->event_args);
+  base::ListValue* event_args = event->event_args.get();
+  ASSERT_EQ(2u, event_args->GetSize());
+  int file_system_id;
+  event_args->GetInteger(0, &file_system_id);
+  EXPECT_EQ(kFileSystemId, file_system_id);
+
+  // Remember the request id, and verify it is valid.
+  int request_id;
+  event_args->GetInteger(0, &request_id);
+  EXPECT_LT(0, request_id);
+
+  // Simulate sending an error response from the providing extension.
+  scoped_ptr<base::DictionaryValue> response(new base::DictionaryValue());
+  bool reply_result =
+      request_manager_->RejectRequest(kExtensionId,
+                                      kFileSystemId,
+                                      request_id,
+                                      base::File::FILE_ERROR_NOT_FOUND);
+  ASSERT_TRUE(reply_result);
+
+  // Callback should be called. Verify the error code.
+  ASSERT_TRUE(logger.error());
+  EXPECT_EQ(base::File::FILE_ERROR_NOT_FOUND, *logger.error());
+}
+
+}  // namespace file_system_provider
+}  // namespace chromeos