Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: third_party/WebKit/Source/modules/permissions/PermissionStatus.h

Issue 2108003002: Merge //content/child/permissions into Blink's permissions module. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/permissions/PermissionStatus.h
diff --git a/third_party/WebKit/Source/modules/permissions/PermissionStatus.h b/third_party/WebKit/Source/modules/permissions/PermissionStatus.h
index 8d1b1e05abd06f64f413198f326d08ec87c75ca9..ec02f77c6aa012abdb8721ffd90711747cc427d5 100644
--- a/third_party/WebKit/Source/modules/permissions/PermissionStatus.h
+++ b/third_party/WebKit/Source/modules/permissions/PermissionStatus.h
@@ -9,9 +9,7 @@
#include "core/dom/ActiveDOMObject.h"
#include "core/events/EventTarget.h"
#include "platform/heap/Handle.h"
-#include "public/platform/modules/permissions/WebPermissionObserver.h"
-#include "public/platform/modules/permissions/WebPermissionStatus.h"
-#include "public/platform/modules/permissions/WebPermissionType.h"
+#include "public/platform/modules/permissions/permission.mojom-blink.h"
#include "wtf/text/AtomicString.h"
#include "wtf/text/WTFString.h"
@@ -25,23 +23,23 @@ class ScriptPromiseResolver;
class PermissionStatus final
: public EventTargetWithInlineData
, public ActiveScriptWrappable
- , public ActiveDOMObject
- , public WebPermissionObserver {
+ , public ActiveDOMObject {
USING_GARBAGE_COLLECTED_MIXIN(PermissionStatus);
DEFINE_WRAPPERTYPEINFO();
+
+ using MojoPermissionName = mojom::blink::PermissionName;
+ using MojoPermissionStatus = mojom::blink::PermissionStatus;
+
public:
- static PermissionStatus* take(ScriptPromiseResolver*, WebPermissionStatus, WebPermissionType);
+ static PermissionStatus* take(ScriptPromiseResolver*, MojoPermissionStatus, MojoPermissionName);
- static PermissionStatus* createAndListen(ExecutionContext*, WebPermissionStatus, WebPermissionType);
+ static PermissionStatus* createAndListen(ExecutionContext*, MojoPermissionStatus, MojoPermissionName);
~PermissionStatus() override;
// EventTarget implementation.
const AtomicString& interfaceName() const override;
ExecutionContext* getExecutionContext() const override;
- // WebPermissionObserver implementation.
- void permissionChanged(WebPermissionType, WebPermissionStatus) override;
-
// ActiveScriptWrappable implementation.
bool hasPendingActivity() const final;
@@ -51,20 +49,21 @@ public:
void stop() override;
String state() const;
+ void permissionChanged(mojom::blink::PermissionStatus);
DEFINE_ATTRIBUTE_EVENT_LISTENER(change);
DECLARE_VIRTUAL_TRACE();
private:
- PermissionStatus(ExecutionContext*, WebPermissionStatus, WebPermissionType);
+ PermissionStatus(ExecutionContext*, MojoPermissionStatus, MojoPermissionName);
void startListening();
void stopListening();
- WebPermissionStatus m_status;
- WebPermissionType m_type;
- bool m_listening;
+ MojoPermissionStatus m_status;
+ MojoPermissionName m_name;
+ mojom::blink::PermissionServicePtr m_service;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698