Add the URLRequest's method and load flags to the NetLog.

Add the URLRequest's method and load flags to the NetLog.

BUG=37421
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47321

[eroman, 2010-05-14 19:04:06]

switched to using url_ instead of original_url_ (so the new URL is displayed
when doing redirects).

[willchan no longer on Chromium, 2010-05-14 19:13:59]

LGTM

http://codereview.chromium.org/2108003/diff/24001/25004
File net/base/net_log_event_type_list.h (right):

http://codereview.chromium.org/2108003/diff/24001/25004#newcode261
net/base/net_log_event_type_list.h:261: //      "method": <The method ("POST" or
"GET" or "HEAD" etc..)>,
Your commas are inconsistent (within this block and also with the file [none of
my multi key params are comma delimited]).  I think you should just ditch them
or make everything else consistent with yours (You should then add a comma at
the end of the line before this one).

http://codereview.chromium.org/2108003/diff/24001/25007
File net/url_request/url_request_netlog_params.cc (right):

http://codereview.chromium.org/2108003/diff/24001/25007#newcode15
net/url_request/url_request_netlog_params.cc:15: dict->SetString(L"url",
url_.possibly_invalid_spec());
Is the URL ever allowed to be invalid here?  I forget when we do the check.

[eroman, 2010-05-14 20:35:27]

Thanks for the review.

http://codereview.chromium.org/2108003/diff/24001/25004
File net/base/net_log_event_type_list.h (right):

http://codereview.chromium.org/2108003/diff/24001/25004#newcode261
net/base/net_log_event_type_list.h:261: //      "method": <The method ("POST" or
"GET" or "HEAD" etc..)>,
On 2010/05/14 19:13:59, willchan wrote:
> Your commas are inconsistent (within this block and also with the file [none
of
> my multi key params are comma delimited]).  I think you should just ditch them
> or make everything else consistent with yours (You should then add a comma at
> the end of the line before this one).

Done.
I added commas where they are missing (the intent with this formatting is to
match JSON).

http://codereview.chromium.org/2108003/diff/24001/25007
File net/url_request/url_request_netlog_params.cc (right):

http://codereview.chromium.org/2108003/diff/24001/25007#newcode15
net/url_request/url_request_netlog_params.cc:15: dict->SetString(L"url",
url_.possibly_invalid_spec());
On 2010/05/14 19:13:59, willchan wrote:
> Is the URL ever allowed to be invalid here?  I forget when we do the check.

I prefer to be on the safe side since this is for logging purposes, and I want
it to work even if some other expectation is wrong.