Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2107953003: [TTS] Protect against an empty Caption for Quick Answers. (Closed)

Created:
4 years, 5 months ago by Donn Denman
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Protect against an empty Caption for Quick Answers. BUG=622219 Committed: https://crrev.com/a54d7427b4786e97cc01c13e652c4ac8a57aca18 Cr-Commit-Position: refs/heads/master@{#402698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Donn Denman
Pedro, PTAL at this trivial change.
4 years, 5 months ago (2016-06-29 00:20:10 UTC) #2
pedro (no code reviews)
lgtm
4 years, 5 months ago (2016-06-29 01:47:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107953003/1
4 years, 5 months ago (2016-06-29 02:13:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 03:08:14 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 03:11:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a54d7427b4786e97cc01c13e652c4ac8a57aca18
Cr-Commit-Position: refs/heads/master@{#402698}

Powered by Google App Engine
This is Rietveld 408576698