Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2107913003:
add short-desc (Closed)
|
Created:
4 years, 5 months ago by reed1 Modified:
4 years, 5 months ago Reviewers:
jcgregorio CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
Descriptionadd short-desc
So that the UI can display the contents of "short-desc" inline with the verb.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2107913003
Committed: https://skia.googlesource.com/skia/+/67f62fae59e982f221d29e2bd0a89a72eaf486bc
Patch Set 1 #Patch Set 2 : change short-desc to just a string #
Total comments: 2
Patch Set 3 : remove global #Messages
Total messages: 19 (9 generated)
Description was changed from ========== add short-desc So that the UI can display the contents of "short-desc" inline with the verb. BUG=skia: ========== to ========== add short-desc So that the UI can display the contents of "short-desc" inline with the verb. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2107913003 ==========
reed@google.com changed reviewers: + jcgregorio@google.com
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
change to just a string. ptal
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2107913003/diff/20001/tools/debugger/SkDrawCo... File tools/debugger/SkDrawCommand.cpp (right): https://codereview.chromium.org/2107913003/diff/20001/tools/debugger/SkDrawCo... tools/debugger/SkDrawCommand.cpp:27: static bool gShowShortDesc = true; Is this really needed? The display of the short desc can be controlled on browser side, why not just always include it in the JSON?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2107913003/diff/20001/tools/debugger/SkDrawCo... File tools/debugger/SkDrawCommand.cpp (right): https://codereview.chromium.org/2107913003/diff/20001/tools/debugger/SkDrawCo... tools/debugger/SkDrawCommand.cpp:27: static bool gShowShortDesc = true; On 2016/06/29 14:43:40, jcgregorio wrote: > Is this really needed? The display of the short desc can be controlled on > browser side, why not just always include it in the JSON? Done.
The CQ bit was checked by reed@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from jcgregorio@google.com Link to the patchset: https://codereview.chromium.org/2107913003/#ps40001 (title: "remove global")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== add short-desc So that the UI can display the contents of "short-desc" inline with the verb. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2107913003 ========== to ========== add short-desc So that the UI can display the contents of "short-desc" inline with the verb. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2107913003 Committed: https://skia.googlesource.com/skia/+/67f62fae59e982f221d29e2bd0a89a72eaf486bc ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/67f62fae59e982f221d29e2bd0a89a72eaf486bc |
