third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp - Issue 2107903002: Repaint non-stacking-context composited children when they scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2107903002: Repaint non-stacking-context composited children when they scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

index 544a1015bd728f69ca0872a87dbb7cd283c9fa65..e6ce0926a2f6682018e280622a60e61e4f4bfe99 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

@@ -383,8 +383,7 @@ void PaintLayerScrollableArea::setScrollOffset(const DoublePoint& newScrollOffse

if (box().view()->compositor()->inCompositingMode()) {

bool onlyScrolledCompositedLayers = scrollsOverflow()

- && !layer()->hasVisibleNonLayerContent()

- && !layer()->hasNonCompositedChild()

+ && layer()->isAllScrollingContentComposited()

&& box().style()->backgroundLayers().attachment() != LocalBackgroundAttachment;

if (usesCompositedScrolling() || onlyScrolledCompositedLayers)

« third_party/WebKit/Source/core/paint/PaintLayer.cpp ('K') | « third_party/WebKit/Source/core/paint/PaintLayer.cpp ('k') | no next file » | no next file with comments »