Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 21079: Fix for Issue 6431 "Two issues about Vietnamese Spell-Checker".... (Closed)

Created:
11 years, 10 months ago by Hironori Bono
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix for Issue 6431 "Two issues about Vietnamese Spell-Checker". This issue is caused by my stupid mistake in the SpellcheckWordIterator class. Unfortunately, the class does not treat combining characters as word characters for languages which uses combining characters (e.g. Vietnamese, Thai, etc.) because the ICU exemplar set is canonicalized and it does not include combining characters. To fix this, this change decomposes an exemplar set and also mark the decomposed characters (including combining characters) as word characters. BUG=6431 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10087

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -21 lines) Patch
M chrome/browser/spellcheck_worditerator.cc View 1 3 chunks +29 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Hironori Bono
11 years, 10 months ago (2009-02-13 11:25:27 UTC) #1
brettw
11 years, 10 months ago (2009-02-13 16:10:44 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698