Support relocatable RPM packages

Support relocatable RPM packages

BUG=31519
Committed: https://crrev.com/c5e796b04c2dffb9bb2023ec6985d5c3457b6e99
Cr-Commit-Position: refs/heads/master@{#402666}

[Tom (Use chromium acct), 2016-06-29 00:43:45]

thomasanderson@google.com changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2016-06-29 00:57:45]

https://codereview.chromium.org/2107893004/diff/1/chrome/installer/linux/rpm/...
File chrome/installer/linux/rpm/chrome.spec.template (left):

https://codereview.chromium.org/2107893004/diff/1/chrome/installer/linux/rpm/...
chrome/installer/linux/rpm/chrome.spec.template:91:
/usr/bin/@@USR_BIN_SYMLINK_NAME@@
Presumably you've installed the RPM and it's not hitting
https://bugs.chromium.org/p/chromium/issues/detail?id=123990 anymore?

[Tom (Use chromium acct), 2016-06-29 01:03:43]

https://codereview.chromium.org/2107893004/diff/1/chrome/installer/linux/rpm/...
File chrome/installer/linux/rpm/chrome.spec.template (left):

https://codereview.chromium.org/2107893004/diff/1/chrome/installer/linux/rpm/...
chrome/installer/linux/rpm/chrome.spec.template:91:
/usr/bin/@@USR_BIN_SYMLINK_NAME@@
On 2016/06/29 00:57:45, Lei Zhang wrote:
> Presumably you've installed the RPM and it's not hitting
> https://bugs.chromium.org/p/chromium/issues/detail?id=123990 anymore?

I didn't see that even before this change

[Tom (Use chromium acct), 2016-06-29 01:03:48]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 01:05:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-06-29 01:07:58]

lgtm

[commit-bot: I haz the power, 2016-06-29 01:59:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 01:59:54]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2016-06-29 02:08:23]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2016-06-29 02:11:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 02:21:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-29 02:23:57]

Description was changed from

==========
Support relocatable RPM packages

BUG=31519
==========

to

==========
Support relocatable RPM packages

BUG=31519

Committed: https://crrev.com/c5e796b04c2dffb9bb2023ec6985d5c3457b6e99
Cr-Commit-Position: refs/heads/master@{#402666}
==========

[commit-bot: I haz the power, 2016-06-29 02:23:58]

Patchset 1 (id:??) landed as
https://crrev.com/c5e796b04c2dffb9bb2023ec6985d5c3457b6e99
Cr-Commit-Position: refs/heads/master@{#402666}

[Tom (Use chromium acct), 2016-09-01 00:22:29]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2299093002/ by thomasanderson@google.com.

The reason for reverting is: Breaks icons on deb packages.

[Michael Moss, 2016-09-01 15:58:41]

mmoss@chromium.org changed reviewers:
+ mmoss@chromium.org

[Michael Moss, 2016-09-01 15:58:42]

https://codereview.chromium.org/2107893004/diff/1/chrome/installer/linux/comm...
File chrome/installer/linux/common/apt.include (left):

https://codereview.chromium.org/2107893004/diff/1/chrome/installer/linux/comm...
chrome/installer/linux/common/apt.include:2: 
While looking into crbug.com/642953, I noticed that this change causes another
issue. Removing variables.include causes REPOCONFIG and REPOCONFIGREGEX to not
be set in the cron.d script, so it won't be able to validate or fix the apt-get
configs.

https://codereview.chromium.org/2107893004/diff/1/chrome/installer/linux/comm...
File chrome/installer/linux/common/rpm.include (left):

https://codereview.chromium.org/2107893004/diff/1/chrome/installer/linux/comm...
chrome/installer/linux/common/rpm.include:2: 
Probably the same REPOCONFIG issue here, since those variables are used in the
script also, and AFAICT, not set anywhere else.