Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: mojo/public/c/system/tests/buffer_unittest.cc

Issue 2107893003: Remove some #ifdef __native_client__ on tests. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/public/c/system/tests/data_pipe_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/c/system/tests/buffer_unittest.cc
diff --git a/mojo/public/c/system/tests/buffer_unittest.cc b/mojo/public/c/system/tests/buffer_unittest.cc
index 9d29dc9035c75608309bea5170ae29d8dc4b1aef..5c5ebe03543e88d4720e49af3e9b8f091ec9ba4d 100644
--- a/mojo/public/c/system/tests/buffer_unittest.cc
+++ b/mojo/public/c/system/tests/buffer_unittest.cc
@@ -40,13 +40,7 @@ TEST(BufferTest, InvalidHandle) {
EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, MojoUnmapBuffer(nullptr));
}
-// TODO(ncbray): enable this test once NaCl supports the corresponding APIs.
-#ifdef __native_client__
-#define MAYBE_Basic DISABLED_Basic
-#else
-#define MAYBE_Basic Basic
-#endif
-TEST(BufferTest, MAYBE_Basic) {
+TEST(BufferTest, Basic) {
// Create a shared buffer (|h0|).
MojoHandle h0 = MOJO_HANDLE_INVALID;
EXPECT_EQ(MOJO_RESULT_OK, MojoCreateSharedBuffer(nullptr, 100, &h0));
« no previous file with comments | « no previous file | mojo/public/c/system/tests/data_pipe_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698