Issue 2107893003: Remove some #ifdef __native_client__ on tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2107893003: Remove some #ifdef __native_client__ on tests. (Closed)

Created:
4 years, 5 months ago by viettrungluu

Modified:
4 years, 5 months ago

Reviewers:
jamesr

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove some #ifdef __native_client__ on tests. These tests were only problematic for SFI NaCl, which is now gone. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2f64806b047b83f7c49e0525d8f3499d7be23e27

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -21 lines)			Patch
M	mojo/public/c/system/tests/buffer_unittest.cc	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	mojo/public/c/system/tests/data_pipe_unittest.cc	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	mojo/public/cpp/system/tests/core_unittest.cc	View	1 chunk	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

4 years, 5 months ago (2016-06-28 22:07:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2f64806b047b83f7c49e0525d8f3499d7be23e27 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages