Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2107883003: Revert of Add display-resolution caching to GPU IDC (Closed)

Created:
4 years, 5 months ago by shans
Modified:
4 years, 5 months ago
Reviewers:
vmpstr, ericrk
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@drt
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add display-resolution caching to GPU IDC (patchset #12 id:410001 of https://codereview.chromium.org/2042133002/ ) Reason for revert: Pretty sure this is causing: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/66769 (and same problem on Mac10.9, 10.10, 10.11) Original issue's description: > Add display-resolution caching to GPU IDC > > In order to save memory and upload time, images which are > going to be drawn at less than their native resolution may > be uploaded at a smaller scale. This change adds additional > caching and upload logic to allow this. > See https://goo.gl/0zCd9Z for a complete description. > > BUG=623688 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;tryserver.blink:mac_blink_rel;tryserver.blink:win_blink_rel > > Committed: https://crrev.com/bc8acf2632042e5e93982088d5b7dcb7f1c0d168 > Committed: https://crrev.com/af0093b301058e5b06ea8a2e84dcf5071545a2b3 > Cr-Original-Commit-Position: refs/heads/master@{#402377} > Cr-Commit-Position: refs/heads/master@{#402694} TBR=vmpstr@chromium.org,ericrk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623688 Committed: https://crrev.com/20f29a6021f7852cea4cc07d912fab5250f9e09a Cr-Commit-Position: refs/heads/master@{#402707}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -1060 lines) Patch
M cc/playback/draw_image.h View 1 chunk +1 line, -5 lines 0 comments Download
M cc/test/geometry_test_utils.h View 1 chunk +0 lines, -6 lines 0 comments Download
M cc/tiles/gpu_image_decode_controller.h View 9 chunks +16 lines, -107 lines 0 comments Download
M cc/tiles/gpu_image_decode_controller.cc View 25 chunks +134 lines, -312 lines 0 comments Download
M cc/tiles/gpu_image_decode_controller_unittest.cc View 10 chunks +54 lines, -594 lines 0 comments Download
M cc/tiles/mipmap_util.h View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/tiles/mipmap_util.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M cc/tiles/mipmap_util_unittest.cc View 7 chunks +5 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
shans
Created Revert of Add display-resolution caching to GPU IDC
4 years, 5 months ago (2016-06-29 03:58:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107883003/1
4 years, 5 months ago (2016-06-29 03:58:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 03:59:58 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 04:01:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20f29a6021f7852cea4cc07d912fab5250f9e09a
Cr-Commit-Position: refs/heads/master@{#402707}

Powered by Google App Engine
This is Rietveld 408576698