Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2107843002: Removes some robolectric residue from JUnit test for ChromeBackgroundServiceWaiter. (Closed)

Created:
4 years, 5 months ago by dougarnett
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes some robolectric residue from JUnit test for ChromeBackgroundServiceWaiter. BUG=612325 Committed: https://crrev.com/8385f6409b5b4a13a079209db6eb37f3593e114c Cr-Commit-Position: refs/heads/master@{#402831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/android/junit/src/org/chromium/chrome/browser/ChromeBackgroundServiceWaiterTest.java View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dougarnett
4 years, 5 months ago (2016-06-28 17:54:48 UTC) #2
Pete Williamson
LGTM as long as tests pass.
4 years, 5 months ago (2016-06-28 17:56:56 UTC) #4
Bernhard Bauer
LGTM
4 years, 5 months ago (2016-06-29 11:30:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107843002/1
4 years, 5 months ago (2016-06-29 16:07:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 16:12:14 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 16:14:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8385f6409b5b4a13a079209db6eb37f3593e114c
Cr-Commit-Position: refs/heads/master@{#402831}

Powered by Google App Engine
This is Rietveld 408576698