Issue 210783003: Only assign environments when they are actually needed. (ia32 only)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 210783003: Only assign environments when they are actually needed. (ia32 only) (Closed)

Created:
6 years, 9 months ago by Sven Panne

Modified:
6 years, 9 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Only assign environments when they are actually needed. (ia32 only) R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20231

Patch Set 2 : Feedback. Rebased. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -47 lines)			Patch
	M	src/ia32/lithium-ia32.cc	View	1	13 chunks	+68 lines, -47 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM. https://codereview.chromium.org/210783003/diff/1/src/ia32/lithium-ia32.cc File src/ia32/lithium-ia32.cc (right): https://codereview.chromium.org/210783003/diff/1/src/ia32/lithium-ia32.cc#newcode1956 src/ia32/lithium-ia32.cc:1956: if (!instr->CanTruncateToInt32()) { we defined the bool "truncating" ...

6 years, 9 months ago (2014-03-25 09:58:24 UTC) #1

Sven Panne

Feedback addressed, landing... https://codereview.chromium.org/210783003/diff/1/src/ia32/lithium-ia32.cc File src/ia32/lithium-ia32.cc (right): https://codereview.chromium.org/210783003/diff/1/src/ia32/lithium-ia32.cc#newcode1956 src/ia32/lithium-ia32.cc:1956: if (!instr->CanTruncateToInt32()) { On 2014/03/25 09:58:24, ...

6 years, 9 months ago (2014-03-25 10:05:09 UTC) #2

Sven Panne

6 years, 9 months ago (2014-03-25 10:17:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20231 (presubmit successful).

Expand Messages | Collapse Messages

Issue 210783003: Only assign environments when they are actually needed. (ia32 only) (Closed)

Description

Patch Set 1 #

Patch Set 2 : Feedback. Rebased. #

Messages