Issue 21078: RegExp parser: Fixed unchecked numeric overflow bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21078: RegExp parser: Fixed unchecked numeric overflow bug. (Closed)

Created:
11 years, 10 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Fixed overflow bug in parsing of regexp repetitions.

Patch Set 1 #

Total comments: 2

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -4 lines)			Patch
M	src/parser.cc	View	3 chunks	+18 lines, -2 lines	2 comments	Download
M	test/mjsunit/regexp.js	View	1 chunk	+34 lines, -1 line	0 comments	Download
M	test/mjsunit/regexp-pcre.js	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/21078/diff/1/2 File src/parser.cc (right): http://codereview.chromium.org/21078/diff/1/2#newcode3957 Line 3957: do { Advance(); } while (IsDecimalDigit(current())); Does ...

11 years, 10 months ago (2009-02-05 11:59:36 UTC) #2

Lasse Reichstein

11 years, 10 months ago (2009-02-05 12:54:41 UTC) #3

http://codereview.chromium.org/21078/diff/1/2
File src/parser.cc (right):

http://codereview.chromium.org/21078/diff/1/2#newcode3957
Line 3957: do { Advance(); } while (IsDecimalDigit(current()));
Yes. Reading current() at end of input is allowed. It gives a special value,
kEndMarker, that definitly isn't a decimal digit.

Expand Messages | Collapse Messages