Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: src/compiler/opcodes.h

Issue 2107783004: [turbofan] Disallow typing for change/checked operators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@TurboFan_RepresentationSelection_Typer
Patch Set: ReferenceEqual foo Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | src/compiler/simplified-operator-reducer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/opcodes.h
diff --git a/src/compiler/opcodes.h b/src/compiler/opcodes.h
index a112ce19b9423940a1ac3f9b226db62be96f3480..e3265084e41162f9431953480c6a31e2d6f079ff 100644
--- a/src/compiler/opcodes.h
+++ b/src/compiler/opcodes.h
@@ -163,6 +163,28 @@
JS_OTHER_OP_LIST(V)
// Opcodes for VirtuaMachine-level operators.
+#define SIMPLIFIED_CHANGE_OP_LIST(V) \
+ V(ChangeTaggedSignedToInt32) \
+ V(ChangeTaggedToInt32) \
+ V(ChangeTaggedToUint32) \
+ V(ChangeTaggedToFloat64) \
+ V(ChangeInt31ToTaggedSigned) \
+ V(ChangeInt32ToTagged) \
+ V(ChangeUint32ToTagged) \
+ V(ChangeFloat64ToTagged) \
+ V(ChangeTaggedToBit) \
+ V(ChangeBitToTagged) \
+ V(TruncateTaggedToWord32) \
+ V(TruncateTaggedToFloat64)
+
+#define SIMPLIFIED_CHECKED_OP_LIST(V) \
+ V(CheckedInt32Add) \
+ V(CheckedInt32Sub) \
+ V(CheckedUint32ToInt32) \
+ V(CheckedFloat64ToInt32) \
+ V(CheckedTaggedToInt32) \
+ V(CheckedTaggedToFloat64)
+
#define SIMPLIFIED_COMPARE_BINOP_LIST(V) \
V(NumberEqual) \
V(NumberLessThan) \
@@ -172,8 +194,7 @@
V(StringLessThan) \
V(StringLessThanOrEqual)
-#define SIMPLIFIED_OP_LIST(V) \
- SIMPLIFIED_COMPARE_BINOP_LIST(V) \
+#define SIMPLIFIED_OTHER_OP_LIST(V) \
V(PlainPrimitiveToNumber) \
V(PlainPrimitiveToWord32) \
V(PlainPrimitiveToFloat64) \
@@ -226,30 +247,12 @@
V(NumberSilenceNaN) \
V(StringFromCharCode) \
V(StringToNumber) \
- V(ChangeTaggedSignedToInt32) \
- V(ChangeTaggedToInt32) \
- V(ChangeTaggedToUint32) \
- V(ChangeTaggedToFloat64) \
- V(ChangeInt31ToTaggedSigned) \
- V(ChangeInt32ToTagged) \
- V(ChangeUint32ToTagged) \
- V(ChangeFloat64ToTagged) \
- V(ChangeTaggedToBit) \
- V(ChangeBitToTagged) \
V(CheckBounds) \
V(CheckNumber) \
V(CheckTaggedPointer) \
V(CheckTaggedSigned) \
- V(CheckedInt32Add) \
- V(CheckedInt32Sub) \
- V(CheckedUint32ToInt32) \
- V(CheckedFloat64ToInt32) \
- V(CheckedTaggedToInt32) \
- V(CheckedTaggedToFloat64) \
V(CheckFloat64Hole) \
V(CheckTaggedHole) \
- V(TruncateTaggedToWord32) \
- V(TruncateTaggedToFloat64) \
V(Allocate) \
V(LoadField) \
V(LoadBuffer) \
@@ -264,6 +267,12 @@
V(ObjectIsString) \
V(ObjectIsUndetectable)
+#define SIMPLIFIED_OP_LIST(V) \
+ SIMPLIFIED_CHANGE_OP_LIST(V) \
+ SIMPLIFIED_CHECKED_OP_LIST(V) \
+ SIMPLIFIED_COMPARE_BINOP_LIST(V) \
+ SIMPLIFIED_OTHER_OP_LIST(V)
+
// Opcodes for Machine-level operators.
#define MACHINE_COMPARE_BINOP_LIST(V) \
V(Word32Equal) \
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | src/compiler/simplified-operator-reducer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698