Pass initial size and GPU preference via context attributes

components/mus/gles2/command_buffer_driver.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/mus/gles2/command_buffer_driver.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 98 matching lines @@
     if (vsync_provider) {
       vsync_provider->GetVSyncParameters(
           base::Bind(&CommandBufferDriver::OnUpdateVSyncParameters,
                      weak_factory_.GetWeakPtr()));
     }
   }
 
   if (!surface_.get())
     return false;
 
   // TODO(piman): virtual contexts, gpu preference.

[danakj, 2016/06/29 18:25:54]

can remove preference here :)

[piman, 2016/06/29 20:28:51]

So, I wouldn't say it's handled yet, the client still can't select the
gpu_preference, but we're ever so slightly closer to that. I moved and clarified
the TODO.

-  context_ = gl::init::CreateGLContext(gpu_state_->share_group(),
-                                       surface_.get(), gl::PreferIntegratedGpu);
+  context_ = gl::init::CreateGLContext(
+      gpu_state_->share_group(), surface_.get(), attrib_helper.gpu_preference);
   if (!context_.get())
     return false;
 
   if (!context_->MakeCurrent(surface_.get()))
     return false;
 
   // TODO(piman): ShaderTranslatorCache is currently per-ContextGroup but
   // only needs to be per-thread.
   const bool bind_generates_resource = attrib_helper.bind_generates_resource;
   scoped_refptr<gpu::gles2::FeatureInfo> feature_info =
@@ skipping 22 matching lines @@
       &CommandBufferDriver::OnFenceSyncRelease, base::Unretained(this)));
   decoder_->SetWaitFenceSyncCallback(base::Bind(
       &CommandBufferDriver::OnWaitFenceSync, base::Unretained(this)));
   decoder_->SetDescheduleUntilFinishedCallback(base::Bind(
       &CommandBufferDriver::OnDescheduleUntilFinished, base::Unretained(this)));
   decoder_->SetRescheduleAfterFinishedCallback(base::Bind(
       &CommandBufferDriver::OnRescheduleAfterFinished, base::Unretained(this)));
 
   gpu::gles2::DisallowedFeatures disallowed_features;
 
-  if (!decoder_->Initialize(surface_, context_, offscreen, gfx::Size(1, 1),
-                            disallowed_features, attrib_helper))
+  if (!decoder_->Initialize(surface_, context_, offscreen, disallowed_features,
+                            attrib_helper))
     return false;
 
   command_buffer_->SetPutOffsetChangeCallback(base::Bind(
       &gpu::CommandExecutor::PutChanged, base::Unretained(executor_.get())));
   command_buffer_->SetGetBufferChangeCallback(base::Bind(
       &gpu::CommandExecutor::SetGetBuffer, base::Unretained(executor_.get())));
   command_buffer_->SetParseErrorCallback(
       base::Bind(&CommandBufferDriver::OnParseError, base::Unretained(this)));
 
   // TODO(piman): other callbacks
@@ skipping 382 matching lines @@
 }
 
 void CommandBufferDriver::OnGpuCompletedSwapBuffers(gfx::SwapResult result) {
   DCHECK(CalledOnValidThread());
   if (client_) {
     client_->OnGpuCompletedSwapBuffers(result);
   }
 }
 
 }  // namespace mus