Issue 2107773002: Adds a crash key to V8EventListener to help diagnose crbug.com/621730 .

Issue 2107773002: Adds a crash key to V8EventListener to help diagnose crbug.com/621730 . (Closed)

Created:
4 years, 5 months ago by Yuki

Modified:
4 years, 5 months ago

Reviewers:
haraken, Robert Sesek, dcheng

CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@crashkey-at-postmessage

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Adds a crash key to V8EventListener to help diagnose crbug.com/621730 . This change can be reverted after a day or two of data. BUG=621730 R=haraken@chromium.org, rsesek@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/d0210f38391ce7282cab3279a1ddcbff6a975d64

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -0 lines)			Patch
M	blimp/engine/app/blimp_engine_crash_keys.cc	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/crash_keys.cc	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp	View		2 chunks	+24 lines, -0 lines	0 comments	Download

Total messages: 8 (3 generated)

Yuki

Could you guys review this CL, too? In addition to https://crrev.com/2101283002 , this CL adds ...

4 years, 5 months ago (2016-06-28 14:05:04 UTC) #2

commit-bot: I haz the power

Patchset 4 (id:??) landed as https://crrev.com/d0210f38391ce7282cab3279a1ddcbff6a975d64 Cr-Commit-Position: refs/heads/master@{#402609}

4 years, 5 months ago (2016-06-29 00:14:34 UTC) #6

Yuki

4 years, 5 months ago (2016-06-29 00:16:08 UTC) #8

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
d0210f38391ce7282cab3279a1ddcbff6a975d64 (presubmit successful).