Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2107733002: [wasm] Use the new Float64Pow TF operator to implement F64Pow. (Closed)

Created:
4 years, 5 months ago by ahaas
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@bmeurer-float64pow
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Use the new Float64Pow TF operator to implement F64Pow. R=bmeurer@chromium.org BUG=v8:5086, v8:5157 Committed: https://crrev.com/fba1a1aa6edf9d860a8b9064e5eccef9f1398d9a Cr-Commit-Position: refs/heads/master@{#37375}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -22 lines) Patch
M src/assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/assembler.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/compiler/wasm-compiler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/external-reference-table.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ahaas
4 years, 5 months ago (2016-06-28 08:25:55 UTC) #1
ahaas
On 2016/06/28 at 08:25:55, ahaas wrote: > Rebase.
4 years, 5 months ago (2016-06-28 13:19:22 UTC) #2
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-06-29 03:55:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107733002/20001
4 years, 5 months ago (2016-06-29 09:21:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 09:35:53 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 09:38:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fba1a1aa6edf9d860a8b9064e5eccef9f1398d9a
Cr-Commit-Position: refs/heads/master@{#37375}

Powered by Google App Engine
This is Rietveld 408576698