Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2107723002: Cap AudioInputSyncWriter "no room in fifo" log messages. (Closed)

Created:
4 years, 5 months ago by Henrik Grunell
Modified:
4 years, 5 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, miu+watch_chromium.org, o1ka, phoglund_chromium, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cap AudioInputSyncWriter "no room in fifo" log messages. Also change log errors to warnings. BUG=589925, 623598 Committed: https://crrev.com/8da4609ddcb6d0394b78fd83b15a25647622383a Cr-Commit-Position: refs/heads/master@{#402749}

Patch Set 1 #

Patch Set 2 : Fix. #

Patch Set 3 : Change cap to 50. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M content/browser/renderer_host/media/audio_input_sync_writer.cc View 1 2 2 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Henrik Grunell
4 years, 5 months ago (2016-06-28 08:30:36 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107723002/20001
4 years, 5 months ago (2016-06-28 08:31:36 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-28 09:24:41 UTC) #7
DaleCurtis
100 seems high, but lgtm
4 years, 5 months ago (2016-06-28 19:00:27 UTC) #8
Henrik Grunell
On 2016/06/28 19:00:27, DaleCurtis wrote: > 100 seems high, but lgtm Yeah perhaps. Changed to ...
4 years, 5 months ago (2016-06-29 06:19:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107723002/40001
4 years, 5 months ago (2016-06-29 06:20:19 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-29 07:32:50 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 07:35:33 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8da4609ddcb6d0394b78fd83b15a25647622383a
Cr-Commit-Position: refs/heads/master@{#402749}

Powered by Google App Engine
This is Rietveld 408576698