Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 21077: Experimental: improve the code generated for possibly boolean-valued... (Closed)

Created:
11 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Experimental: improve the code generated for possibly boolean-valued expressions. Instead of branching to the true control target and jumping to the false one, track which one is the preferred fall-through. Use this to branch to the non-fall-through and bind the fall-through. This avoids a jump to the next instruction or else a branch around a jump. It becomes more difficult to tell if we have compiled an expression into control flow or not. Committed: http://code.google.com/p/v8/source/detail?r=1235

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -138 lines) Patch
M src/codegen-ia32.h View 8 chunks +32 lines, -6 lines 0 comments Download
M src/codegen-ia32.cc View 1 36 chunks +185 lines, -131 lines 0 comments Download
M src/disassembler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Kevin Millikin (Chromium)
11 years, 10 months ago (2009-02-05 10:43:14 UTC) #1
This is a little complicated.

As another change, I plan to abstract the triple of jump targets into a single
class with the branching behavior and the state to tell if they've been used.

Powered by Google App Engine
This is Rietveld 408576698