Issue 2107683002: [wasm] Forbid sign mismatch in asm typer.

Issue 2107683002: [wasm] Forbid sign mismatch in asm typer. (Closed)

Created:
4 years, 5 months ago by bradnelson

Modified:
4 years, 5 months ago

Reviewers:
aseemgarg, bradn

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[wasm] Forbid sign mismatch in asm typer. asm.js forbids mixing signed and unsigned % or /. We had been allowing these. Fixes crash. BUG=618602 BUG=v8:4203 R=aseemgarg@chromium.org Committed: https://crrev.com/c5856779ebfa3d2a3772035a0414b1575db76be1 Cr-Commit-Position: refs/heads/master@{#37350}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -3 lines)			Patch
M	src/typing-asm.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	test/cctest/test-asm-validator.cc	View	1 chunk	+34 lines, -1 line	0 comments	Download
A	test/mjsunit/regress/regress-wasm-crbug-618602.js	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	test/mjsunit/wasm/asm-wasm-i32.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 9 (4 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107683002/1

4 years, 5 months ago (2016-06-28 20:55:37 UTC) #5

commit-bot: I haz the power

4 years, 5 months ago (2016-06-28 21:01:48 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c5856779ebfa3d2a3772035a0414b1575db76be1
Cr-Commit-Position: refs/heads/master@{#37350}