X87: [cleanup] Remove dead code from DeclareLookupSlot and rename it.

X87: [cleanup] Remove dead code from DeclareLookupSlot and rename it.

  port cbc6adc86cc2697785d311ff5bf9f736c7d9e725 (r37111)

  original commit message:
  Runtime_DeclareLookupSlot is used when generating code for var and function declarations
  originating in an eval. Over time, it's accumulated quite a bit of cruft, which this CL removes:

    - With legacy const gone, lookup slots never have any property attributes.
    - There was a bit signaling that the variable was from an eval, but that was redundant since
      DeclareLookupSlot is only used for eval.
    - Some Proxy-related code didn't make sense here.

  Its name was also not terribly clear: while "LookupSlot" is used in several places, this
  particular function is only used for declaring variables and functions inside sloppy eval.
  Renamed (and split into two) to make this clear for future archeologists.

  Also added various DCHECKs to check the assumptions being made.

BUG=

Committed: https://crrev.com/43d0b7e7650baf37fc499461b9cd9646cac767a5
Cr-Commit-Position: refs/heads/master@{#37317}

[zhengxing.li, 2016-06-28 05:56:14]

zhengxing.li@intel.com changed reviewers:
+ adamk@chromium.org, chunyang.dai@intel.com, weiliang.lin@intel.com

[zhengxing.li, 2016-06-28 05:56:14]

PTAL, thanks!

[Weiliang, 2016-06-28 06:35:14]

lgtm

[zhengxing.li, 2016-06-28 08:04:32]

The CQ bit was checked by zhengxing.li@intel.com

[commit-bot: I haz the power, 2016-06-28 08:04:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 08:31:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-28 08:33:12]

Description was changed from

==========
X87: [cleanup] Remove dead code from DeclareLookupSlot and rename it.

  port cbc6adc86cc2697785d311ff5bf9f736c7d9e725 (r37111)

  original commit message:
  Runtime_DeclareLookupSlot is used when generating code for var and function
declarations
  originating in an eval. Over time, it's accumulated quite a bit of cruft,
which this CL removes:

    - With legacy const gone, lookup slots never have any property attributes.
    - There was a bit signaling that the variable was from an eval, but that was
redundant since
      DeclareLookupSlot is only used for eval.
    - Some Proxy-related code didn't make sense here.

  Its name was also not terribly clear: while "LookupSlot" is used in several
places, this
  particular function is only used for declaring variables and functions inside
sloppy eval.
  Renamed (and split into two) to make this clear for future archeologists.

  Also added various DCHECKs to check the assumptions being made.

BUG=
==========

to

==========
X87: [cleanup] Remove dead code from DeclareLookupSlot and rename it.

  port cbc6adc86cc2697785d311ff5bf9f736c7d9e725 (r37111)

  original commit message:
  Runtime_DeclareLookupSlot is used when generating code for var and function
declarations
  originating in an eval. Over time, it's accumulated quite a bit of cruft,
which this CL removes:

    - With legacy const gone, lookup slots never have any property attributes.
    - There was a bit signaling that the variable was from an eval, but that was
redundant since
      DeclareLookupSlot is only used for eval.
    - Some Proxy-related code didn't make sense here.

  Its name was also not terribly clear: while "LookupSlot" is used in several
places, this
  particular function is only used for declaring variables and functions inside
sloppy eval.
  Renamed (and split into two) to make this clear for future archeologists.

  Also added various DCHECKs to check the assumptions being made.

BUG=

Committed: https://crrev.com/43d0b7e7650baf37fc499461b9cd9646cac767a5
Cr-Commit-Position: refs/heads/master@{#37317}
==========

[commit-bot: I haz the power, 2016-06-28 08:33:13]

Patchset 1 (id:??) landed as
https://crrev.com/43d0b7e7650baf37fc499461b9cd9646cac767a5
Cr-Commit-Position: refs/heads/master@{#37317}