Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 210763003: Handlify GetElementWithReceiver and GetElementWithInterceptor. (Closed)

Created:
6 years, 9 months ago by Yang
Modified:
6 years, 9 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Handlify GetElementWithReceiver and GetElementWithInterceptor. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20230

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -87 lines) Patch
M src/builtins.cc View 1 3 chunks +4 lines, -19 lines 0 comments Download
M src/objects.h View 1 2 chunks +8 lines, -5 lines 0 comments Download
M src/objects.cc View 1 2 chunks +49 lines, -47 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +2 lines, -12 lines 0 comments Download
M src/runtime.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 9 months ago (2014-03-25 08:11:14 UTC) #1
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/210763003/diff/1/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/210763003/diff/1/src/builtins.cc#newcode509 src/builtins.cc:509: backing_store.is_null() ? *backing_store : NULL); ...
6 years, 9 months ago (2014-03-25 09:48:53 UTC) #2
Yang
On 2014/03/25 09:48:53, Igor Sheludko wrote: > lgtm with a nit: > > https://codereview.chromium.org/210763003/diff/1/src/builtins.cc > ...
6 years, 9 months ago (2014-03-25 10:04:59 UTC) #3
Yang
6 years, 9 months ago (2014-03-25 10:15:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20230 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698