[Findit] Adding support for splitting try job data by trybot

[Findit] Adding support for splitting try job data by trybot

Adding the -T flag for splitting by try bot name (not to be confused with -t which splits by try job type).

Example:
python try_job_data_metrics.py -T

linux_chromium_variable
  <stats> ...
win_chromium_variable
  <stats> ...
...

BUG=623768
Committed: https://chromium.googlesource.com/infra/infra/+/e3e86c2c0e1cd7392fd62ba30ae52fcd945a98b1

[lijeffrey, 2016-06-27 23:59:45]

Description was changed from

==========
[Findit] Adding support for splitting try job data by trybot

BUG=
==========

to

==========
[Findit] Adding support for splitting try job data by trybot

Adding the -T flag for splitting by try bot name (not to be confused with -t
which splits by try job type).

Example:
python try_job_data_metrics.py -T

linux_chromium_variable
  <stats> ...
win_chromium_variable
  <stats> ...
...

BUG=623768
==========

[lijeffrey, 2016-06-27 23:59:45]

lijeffrey@chromium.org changed reviewers:
+ chanli@chromium.org, stgao@chromium.org

[lijeffrey, 2016-06-28 00:01:09]

ptal

This change should allow us to switch try bots over to super bots and monitor
them over time. Note in order to differentiate the try jobs the date for which
the new super bots are added need to be recorded and used as input to avoid
contaminating the performance data.

[stgao, 2016-06-29 01:00:59]

On 2016/06/28 00:01:09, lijeffrey wrote:
> ptal
> 
> This change should allow us to switch try bots over to super bots and monitor
> them over time. Note in order to differentiate the try jobs the date for which
> the new super bots are added need to be recorded and used as input to avoid
> contaminating the performance data.
Do you have a record of when the master was reboot after the super-bot was
added?

lgtm with a nit

[stgao, 2016-06-29 01:01:13]

https://codereview.chromium.org/2107623002/diff/1/appengine/findit/util_scrip...
File appengine/findit/util_scripts/remote_queries/try_job_data_metrics.py
(right):

https://codereview.chromium.org/2107623002/diff/1/appengine/findit/util_scrip...
appengine/findit/util_scripts/remote_queries/try_job_data_metrics.py:505:
help='group try job data by trybot')
how about "--trybot" instead of the short version "-T" to avoid confusion with
"-t"?

[chanli, 2016-06-29 23:17:05]

On 2016/06/29 01:01:13, stgao wrote:
>
https://codereview.chromium.org/2107623002/diff/1/appengine/findit/util_scrip...
> File appengine/findit/util_scripts/remote_queries/try_job_data_metrics.py
> (right):
> 
>
https://codereview.chromium.org/2107623002/diff/1/appengine/findit/util_scrip...
> appengine/findit/util_scripts/remote_queries/try_job_data_metrics.py:505:
> help='group try job data by trybot')
> how about "--trybot" instead of the short version "-T" to avoid confusion with
> "-t"?

lgtm

[lijeffrey, 2016-06-30 01:38:48]

The CQ bit was checked by lijeffrey@chromium.org

[lijeffrey, 2016-06-30 01:38:49]

The patchset sent to the CQ was uploaded after l-g-t-m from chanli@chromium.org,
stgao@chromium.org
Link to the patchset: https://codereview.chromium.org/2107623002/#ps20001
(title: "Addressing comments")

[lijeffrey, 2016-06-30 01:38:55]

https://codereview.chromium.org/2107623002/diff/1/appengine/findit/util_scrip...
File appengine/findit/util_scripts/remote_queries/try_job_data_metrics.py
(right):

https://codereview.chromium.org/2107623002/diff/1/appengine/findit/util_scrip...
appengine/findit/util_scripts/remote_queries/try_job_data_metrics.py:505:
help='group try job data by trybot')
On 2016/06/29 01:01:13, stgao wrote:
> how about "--trybot" instead of the short version "-T" to avoid confusion with
> "-t"?

Done.

[commit-bot: I haz the power, 2016-06-30 01:38:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 01:52:54]

Description was changed from

==========
[Findit] Adding support for splitting try job data by trybot

Adding the -T flag for splitting by try bot name (not to be confused with -t
which splits by try job type).

Example:
python try_job_data_metrics.py -T

linux_chromium_variable
  <stats> ...
win_chromium_variable
  <stats> ...
...

BUG=623768
==========

to

==========
[Findit] Adding support for splitting try job data by trybot

Adding the -T flag for splitting by try bot name (not to be confused with -t
which splits by try job type).

Example:
python try_job_data_metrics.py -T

linux_chromium_variable
  <stats> ...
win_chromium_variable
  <stats> ...
...

BUG=623768

Committed:
https://chromium.googlesource.com/infra/infra/+/e3e86c2c0e1cd7392fd62ba30ae52...
==========

[commit-bot: I haz the power, 2016-06-30 01:52:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/e3e86c2c0e1cd7392fd62ba30ae52...