chrome/browser/ui/views/tabs/tab.cc - Issue 2107603002: Makes the pinned tab title change indicator hide correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab.cc

Issue 2107603002: Makes the pinned tab title change indicator hide correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/tabs/tab.cc

diff --git a/chrome/browser/ui/views/tabs/tab.cc b/chrome/browser/ui/views/tabs/tab.cc

index 3da5cd70530f9c9ca0cef8c232b9ef73d776a9ed..c7406404df139709833a4053ff33bb8f492659e7 100644

--- a/chrome/browser/ui/views/tabs/tab.cc

+++ b/chrome/browser/ui/views/tabs/tab.cc

@@ -571,6 +571,10 @@ bool Tab::IsActive() const {

}

void Tab::ActiveStateChanged() {

+ // The pinned tab title changed indicator is only shown for inactive tabs.

+ // When transitioning between active and inactive already reset the state

Evan Stade 2016/06/28 00:09:05 the "already" in this sentence is kinda throwing m

sky 2016/06/28 03:04:15 Should be always. Changed.

+ // to enforce that.

+ SetPinnedTabTitleChangedIndicatorVisible(false);

OnButtonColorMaybeChanged();

alert_indicator_button_->UpdateEnabledForMuteToggle();

Layout();

« chrome/browser/ui/views/tabs/tab.h ('K') | « chrome/browser/ui/views/tabs/tab.h ('k') | chrome/browser/ui/views/tabs/tab_strip.cc » ('j') | no next file with comments »