Makes the pinned tab title change indicator hide correctly

Makes the pinned tab title change indicator hide correctly

It was not properly hiding if the indicator was shown and the tab
becomes active.

BUG=623746
TEST=covered by test
R=estade@chromium.org

Committed: https://crrev.com/e0ee995ba7c1e9a35ae85a50dbc76a35906ac31d
Cr-Commit-Position: refs/heads/master@{#402492}

[Evan Stade, 2016-06-28 00:09:05]

lgtm

https://codereview.chromium.org/2107603002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/tabs/tab.cc (right):

https://codereview.chromium.org/2107603002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/tab.cc:575: // When transitioning between active
and inactive already reset the state
the "already" in this sentence is kinda throwing me off.

https://codereview.chromium.org/2107603002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/tabs/tab.h (right):

https://codereview.chromium.org/2107603002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/tab.h:102: bool
showing_pinned_tab_title_changed_indicator() const {
instead of adding this here, can we make an accessor in TabStripTest (which is
already friended)

[sky, 2016-06-28 03:04:16]

https://codereview.chromium.org/2107603002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/tabs/tab.cc (right):

https://codereview.chromium.org/2107603002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/tab.cc:575: // When transitioning between active
and inactive already reset the state
On 2016/06/28 00:09:05, Evan Stade wrote:
> the "already" in this sentence is kinda throwing me off.

Should be always. Changed.

https://codereview.chromium.org/2107603002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/tabs/tab.h (right):

https://codereview.chromium.org/2107603002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/tab.h:102: bool
showing_pinned_tab_title_changed_indicator() const {
On 2016/06/28 00:09:05, Evan Stade wrote:
> instead of adding this here, can we make an accessor in TabStripTest (which is
> already friended)

Done.

[sky, 2016-06-28 03:05:40]

The CQ bit was checked by sky@chromium.org

[sky, 2016-06-28 03:05:40]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2107603002/#ps40001
(title: "feedback")

[commit-bot: I haz the power, 2016-06-28 03:05:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 03:15:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 03:15:34]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[sky, 2016-06-28 16:41:38]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-06-28 16:43:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 16:58:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-28 17:01:57]

Description was changed from

==========
Makes the pinned tab title change indicator hide correctly

It was not properly hiding if the indicator was shown and the tab
becomes active.

BUG=623746
TEST=covered by test
R=estade@chromium.org
==========

to

==========
Makes the pinned tab title change indicator hide correctly

It was not properly hiding if the indicator was shown and the tab
becomes active.

BUG=623746
TEST=covered by test
R=estade@chromium.org

Committed: https://crrev.com/e0ee995ba7c1e9a35ae85a50dbc76a35906ac31d
Cr-Commit-Position: refs/heads/master@{#402492}
==========

[commit-bot: I haz the power, 2016-06-28 17:01:58]

Patchset 3 (id:??) landed as
https://crrev.com/e0ee995ba7c1e9a35ae85a50dbc76a35906ac31d
Cr-Commit-Position: refs/heads/master@{#402492}