Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 210753002: Remove EventPath::parent() in favor of NodeRenderingTraversal::parent(). (Closed)

Created:
6 years, 9 months ago by hayato
Modified:
6 years, 9 months ago
Reviewers:
esprehn, dglazkov
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Remove EventPath::parent() in favor of NodeRenderingTraversal::parent(). EventPath::parent() is only used in adjusting the result of HitTest in some places. For example, if a text node is clicked, we have to adjust the result to the *reasonable* parent element of the text node. In adjusting, we should use NodeRenderingTraversal::parent() instead of EventPath::parent(). That means the adjusted result is no longer shadow roots or insertion points. The result would be the parent element of the text node in the composed tree. That should make sense because neither shadow roots nor insertion points are rendered. BUG=354366 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169923

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -25 lines) Patch
M LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node.html View 1 chunk +4 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt View 2 chunks +8 lines, -7 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/events/EventPath.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/EventPath.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hayato
PTAL
6 years, 9 months ago (2014-03-25 05:40:27 UTC) #1
esprehn
On 2014/03/25 05:40:27, hayato wrote: > PTAL Lgtm, awesome!
6 years, 9 months ago (2014-03-25 06:20:58 UTC) #2
hayato
The CQ bit was checked by hayato@chromium.org
6 years, 9 months ago (2014-03-25 06:28:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/210753002/1
6 years, 9 months ago (2014-03-25 06:28:20 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 06:51:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-25 06:51:52 UTC) #6
hayato
The CQ bit was checked by hayato@chromium.org
6 years, 9 months ago (2014-03-25 07:56:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/210753002/1
6 years, 9 months ago (2014-03-25 07:56:18 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 08:55:33 UTC) #9
Message was sent while issue was closed.
Change committed as 169923

Powered by Google App Engine
This is Rietveld 408576698