Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2107513002: AIX: Adding bbigtoc link step option to fix TOC overflow error (Closed)

Created:
4 years, 5 months ago by JaideepBajwa
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

AIX: Adding bbigtoc link step option to fix TOC overflow error Adding link option -bbigtoc to fix TOC overflow error. The option instructs the linker to generate TOC larger than 64k. TOC: http://www.ibm.com/developerworks/rational/library/overview-toc-aix/ R=machenbach@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/1ef7e4e2a6b913b1b43e887f83f3f8ef27382309 Cr-Commit-Position: refs/heads/master@{#37327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gypfiles/toolchain.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
JaideepBajwa
PTAL
4 years, 5 months ago (2016-06-27 19:51:20 UTC) #1
john.yan
lgtm
4 years, 5 months ago (2016-06-27 19:59:49 UTC) #2
Michael Achenbach
lgtm
4 years, 5 months ago (2016-06-28 05:52:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107513002/1
4 years, 5 months ago (2016-06-28 12:21:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 12:44:56 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 12:45:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ef7e4e2a6b913b1b43e887f83f3f8ef27382309
Cr-Commit-Position: refs/heads/master@{#37327}

Powered by Google App Engine
This is Rietveld 408576698