components/webdata_services/web_data_service_wrapper.h - Issue 2107493002: Offer user to send feedback from profile error dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/webdata_services/web_data_service_wrapper.h

Issue 2107493002: Offer user to send feedback from profile error dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sky's comments and some improvements to the code. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/webdata/common/web_database_backend.cc ('K') | « components/webdata/common/web_database_service.cc ('k') | ios/chrome/browser/browser_state/test_chrome_browser_state.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/webdata_services/web_data_service_wrapper.h

diff --git a/components/webdata_services/web_data_service_wrapper.h b/components/webdata_services/web_data_service_wrapper.h

index ecc8c33d3a3f579dd0051e705d58586c0b86aeb4..1c44eaccd379bcba53b0f19ecb25d3acbdea2cd6 100644

--- a/components/webdata_services/web_data_service_wrapper.h

+++ b/components/webdata_services/web_data_service_wrapper.h

@@ -46,7 +46,9 @@ class WebDataServiceWrapper : public KeyedService {

};

// Shows an error message if a loading error occurs.

sky 2016/08/02 13:27:21 Again, document parameters.

afakhry 2016/08/02 23:58:25 Done. This is a different one than the previous co

- using ShowErrorCallback = void (*)(ErrorType, sql::InitStatus);

+ using ShowErrorCallback = void (*)(ErrorType,

+ sql::InitStatus,

+ const std::string&);

// Constructor for WebDataServiceWrapper that initializes the different

// WebDataServices and starts the synchronization services using |flare|.