chrome/browser/web_data_service_factory.cc - Issue 2107493002: Offer user to send feedback from profile error dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_data_service_factory.cc

Issue 2107493002: Offer user to send feedback from profile error dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Avoid a ref loop. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/simple_message_box_views.cc ('K') | « chrome/browser/ui/views/simple_message_box_views.cc ('k') | chrome/test/base/testing_profile.cc » ('j') | sql/connection.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/web_data_service_factory.cc

diff --git a/chrome/browser/web_data_service_factory.cc b/chrome/browser/web_data_service_factory.cc

index 8cac57d74bae0c8611ca2db0d8906cf3e0d712a5..827aee89066260c951e847cd3f8172e89acc38b4 100644

--- a/chrome/browser/web_data_service_factory.cc

+++ b/chrome/browser/web_data_service_factory.cc

@@ -55,11 +55,13 @@ ProfileErrorType ProfileErrorFromWebDataServiceWrapperError(

// Callback to show error dialog on profile load error.

void ProfileErrorCallback(WebDataServiceWrapper::ErrorType error_type,

- sql::InitStatus status) {

- ShowProfileErrorDialog(

- ProfileErrorFromWebDataServiceWrapperError(error_type),

- (status == sql::INIT_FAILURE) ?

- IDS_COULDNT_OPEN_PROFILE_ERROR : IDS_PROFILE_TOO_NEW_ERROR);

+ sql::InitStatus status,

+ const std::string& diagnostics) {

+ ShowProfileErrorDialog(ProfileErrorFromWebDataServiceWrapperError(error_type),

+ (status == sql::INIT_FAILURE)

+ ? IDS_COULDNT_OPEN_PROFILE_ERROR

+ : IDS_PROFILE_TOO_NEW_ERROR,

+ diagnostics);

}

} // namespace

« chrome/browser/ui/views/simple_message_box_views.cc ('K') | « chrome/browser/ui/views/simple_message_box_views.cc ('k') | chrome/test/base/testing_profile.cc » ('j') | sql/connection.cc » ('J')