components/webdata/common/web_database_service.h - Issue 2107493002: Offer user to send feedback from profile error dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/webdata/common/web_database_service.h

Issue 2107493002: Offer user to send feedback from profile error dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Yet more compile errors Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/webdata/common/web_database_backend.cc ('K') | « components/webdata/common/web_database_backend.cc ('k') | components/webdata/common/web_database_service.cc » ('j') | components/webdata/common/web_database_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/webdata/common/web_database_service.h

diff --git a/components/webdata/common/web_database_service.h b/components/webdata/common/web_database_service.h

index 2c68a3b01058b51a17f7345e9a7b0bccfbb5ac31..8b2d433aac77c743be8bbfebf747ef24472c827e 100644

--- a/components/webdata/common/web_database_service.h

+++ b/components/webdata/common/web_database_service.h

@@ -55,7 +55,9 @@ class WEBDATA_EXPORT WebDatabaseService

// Types for managing DB loading callbacks.

typedef base::Closure DBLoadedCallback;

- typedef base::Callback<void(sql::InitStatus)> DBLoadErrorCallback;

+ typedef base::Callback<void(sql::InitStatus,

Lei Zhang 2016/07/09 01:04:47 typedef foo bar -> using bar = foo;

afakhry 2016/07/11 16:47:45 Done.

+ const sql::DatabaseDiagnosticMap&)>

+ DBLoadErrorCallback;

// Takes the path to the WebDatabase file.

// WebDatabaseService lives on |ui_thread| and posts tasks to |db_thread|.

@@ -124,7 +126,8 @@ class WEBDATA_EXPORT WebDatabaseService

virtual ~WebDatabaseService();

- void OnDatabaseLoadDone(sql::InitStatus status);

+ void OnDatabaseLoadDone(sql::InitStatus status,

+ const sql::DatabaseDiagnosticMap& diagnostics);

base::FilePath path_;