Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2107453002: Fix Perlin noise fuzz issue (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix Perlin noise fuzz issue The main "fix" here was that the assert was checking the un-clamped input value rather than the clamped value. The SkValidatingReadBuffer.cpp change was required to get the reproducing fuzz test case to complete. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2107453002 Committed: https://skia.googlesource.com/skia/+/6a16fd33da4e77ced87a46fa346a6095ceea8899

Patch Set 1 #

Patch Set 2 : Working #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/core/SkValidatingReadBuffer.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
robertphillips
4 years, 5 months ago (2016-06-27 19:03:26 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107453002/20001
4 years, 5 months ago (2016-06-27 19:04:25 UTC) #7
bsalomon
4 years, 5 months ago (2016-06-27 19:15:10 UTC) #8
bsalomon
On 2016/06/27 19:15:10, bsalomon wrote: lgtm
4 years, 5 months ago (2016-06-27 19:15:20 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-27 19:20:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107453002/20001
4 years, 5 months ago (2016-06-27 19:25:36 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 19:26:33 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6a16fd33da4e77ced87a46fa346a6095ceea8899

Powered by Google App Engine
This is Rietveld 408576698