Issue 210743002: Revert 259154 "Remove HasAudio(), HasVideo(), GetInitialNaturalS..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 210743002: Revert 259154 "Remove HasAudio(), HasVideo(), GetInitialNaturalS..." (Closed)

Created:
6 years, 9 months ago by viettrungluu

Modified:
6 years, 9 months ago

Reviewers:
sandersd (OOO until July 31)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 259154 "Remove HasAudio(), HasVideo(), GetInitialNaturalS..." Broke various builds (in particular, media/tools/player_x11/player_x11.cc doesn't compile). > Remove HasAudio(), HasVideo(), GetInitialNaturalSize() from media::Pipeline. > > This splits PipelineBufferingStateCB in two: PipelineMetadataCB, which includes the available tracks and natural size in a PipelineMetadata struct; and PipelinePrerollCompleted, with no parameters. Now WebMediaPlayerImpl can cache the metadata and the accessors are not required. > > BUG=148541 > > Review URL: https://codereview.chromium.org/206103004 TBR=sandersd@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259159

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+201 lines, -154 lines)			Patch
M	trunk/src/content/renderer/media/webmediaplayer_impl.h	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	trunk/src/content/renderer/media/webmediaplayer_impl.cc	View	5 chunks	+29 lines, -31 lines	0 comments	Download
M	trunk/src/media/base/pipeline.h	View	9 chunks	+48 lines, -25 lines	0 comments	Download
M	trunk/src/media/base/pipeline.cc	View	12 chunks	+64 lines, -35 lines	0 comments	Download
M	trunk/src/media/base/pipeline_unittest.cc	View	22 chunks	+35 lines, -33 lines	0 comments	Download
M	trunk/src/media/filters/pipeline_integration_test.cc	View	3 chunks	+10 lines, -11 lines	0 comments	Download
M	trunk/src/media/filters/pipeline_integration_test_base.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	trunk/src/media/filters/pipeline_integration_test_base.cc	View	4 chunks	+11 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

Committed patchset #1 manually as r259159 (tree was closed).

6 years, 9 months ago (2014-03-25 05:38:21 UTC) #2

sandersd (OOO until July 31)

6 years, 9 months ago (2014-03-25 17:51:19 UTC) #3

Message was sent while issue was closed.

On 2014/03/25 05:38:21, viettrungluu wrote:
> Committed patchset #1 manually as r259159 (tree was closed).

lgtm.

Sorry, forgot player_x11 exists :-(

Expand Messages | Collapse Messages