Certificate Transparency: MerkleTreeLeaf, MerkleAuditProof improvements.

Certificate Transparency: MerkleTreeLeaf, MerkleAuditProof improvements.

Per comments on another code review, I've documented MerkleTreeLeaf and
changed the Hash function name.

This change also adds the tree size to the MerkleAuditProof, as each
proof ties to a particular tree size (and it can't directly be
deduced from the number of nodes in the proof).

BUG=613495
Committed: https://crrev.com/b38ec0a4aaf590b21c1344a5962bcfeb65f3e3d6
Cr-Commit-Position: refs/heads/master@{#404356}

[Eran Messeri, 2016-07-01 10:11:02]

Description was changed from

==========
Certificate Transparency: MerkleTreeLeaf, MerkleAuditProof improvements.

Per comments on another code review, I've documented MerkleTreeLeaf and
changed the Hash function name.

This change also adds the tree size to the MerkleAuditProof, as each
proof ties to a particular tree size (and it can't directly be
deduced from the number of nodes in the proof).

BUG=613495
==========

to

==========
Certificate Transparency: MerkleTreeLeaf, MerkleAuditProof improvements.

Per comments on another code review, I've documented MerkleTreeLeaf and
changed the Hash function name.

This change also adds the tree size to the MerkleAuditProof, as each
proof ties to a particular tree size (and it can't directly be
deduced from the number of nodes in the proof).

BUG=613495
==========

[Eran Messeri, 2016-07-01 10:11:02]

eranm@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Eran Messeri, 2016-07-01 10:11:20]

Ryan, this change addresses comments you've made about the MerkleTreeLeaf in
another CL.

[Ryan Sleevi, 2016-07-06 19:16:04]

LGTM w/o the MerkleAuditProof changes, because it's impossible for me to review
if it's the right direction, given that the code using this is not wired up.

I'm happy and encouraging to revisit this class once we can look at more
concrete use cases.

[Eran Messeri, 2016-07-08 10:24:25]

The CQ bit was checked by eranm@chromium.org

[Eran Messeri, 2016-07-08 10:24:25]

The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/2107423004/#ps60001
(title: "Fixing botched merge")

[commit-bot: I haz the power, 2016-07-08 10:25:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 14:10:57]

Description was changed from

==========
Certificate Transparency: MerkleTreeLeaf, MerkleAuditProof improvements.

Per comments on another code review, I've documented MerkleTreeLeaf and
changed the Hash function name.

This change also adds the tree size to the MerkleAuditProof, as each
proof ties to a particular tree size (and it can't directly be
deduced from the number of nodes in the proof).

BUG=613495
==========

to

==========
Certificate Transparency: MerkleTreeLeaf, MerkleAuditProof improvements.

Per comments on another code review, I've documented MerkleTreeLeaf and
changed the Hash function name.

This change also adds the tree size to the MerkleAuditProof, as each
proof ties to a particular tree size (and it can't directly be
deduced from the number of nodes in the proof).

BUG=613495
==========

[commit-bot: I haz the power, 2016-07-08 14:10:58]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-08 14:11:11]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 14:12:58]

Description was changed from

==========
Certificate Transparency: MerkleTreeLeaf, MerkleAuditProof improvements.

Per comments on another code review, I've documented MerkleTreeLeaf and
changed the Hash function name.

This change also adds the tree size to the MerkleAuditProof, as each
proof ties to a particular tree size (and it can't directly be
deduced from the number of nodes in the proof).

BUG=613495
==========

to

==========
Certificate Transparency: MerkleTreeLeaf, MerkleAuditProof improvements.

Per comments on another code review, I've documented MerkleTreeLeaf and
changed the Hash function name.

This change also adds the tree size to the MerkleAuditProof, as each
proof ties to a particular tree size (and it can't directly be
deduced from the number of nodes in the proof).

BUG=613495

Committed: https://crrev.com/b38ec0a4aaf590b21c1344a5962bcfeb65f3e3d6
Cr-Commit-Position: refs/heads/master@{#404356}
==========

[commit-bot: I haz the power, 2016-07-08 14:12:59]

Patchset 4 (id:??) landed as
https://crrev.com/b38ec0a4aaf590b21c1344a5962bcfeb65f3e3d6
Cr-Commit-Position: refs/heads/master@{#404356}