Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 21074004: Cleaning up HAllocate space and double alignment selection. (Closed)

Created:
7 years, 4 months ago by Hannes Payer (out of office)
Modified:
7 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Cleaning up HAllocate space and double alignment selection. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16000

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -45 lines) Patch
M src/code-stubs-hydrogen.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M src/heap.h View 1 2 3 4 3 chunks +6 lines, -8 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 4 9 chunks +32 lines, -17 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 3 4 3 chunks +13 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hannes Payer (out of office)
7 years, 4 months ago (2013-07-31 14:22:47 UTC) #1
Michael Starzinger
https://codereview.chromium.org/21074004/diff/1/src/heap.h File src/heap.h (right): https://codereview.chromium.org/21074004/diff/1/src/heap.h#newcode486 src/heap.h:486: enum AllocationMode { NEW_SPACE_ALLOCATION, OLD_SPACE_ALLOCATION }; Why not use ...
7 years, 4 months ago (2013-07-31 16:43:16 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/21074004/diff/1/src/heap.h File src/heap.h (right): https://codereview.chromium.org/21074004/diff/1/src/heap.h#newcode486 src/heap.h:486: enum AllocationMode { NEW_SPACE_ALLOCATION, OLD_SPACE_ALLOCATION }; On 2013/07/31 16:43:16, ...
7 years, 4 months ago (2013-08-01 07:30:57 UTC) #3
Michael Starzinger
LGTM.
7 years, 4 months ago (2013-08-01 07:51:04 UTC) #4
Hannes Payer (out of office)
7 years, 4 months ago (2013-08-01 08:34:44 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 manually as r16000 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698