Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Unified Diff: sdk/lib/_internal/compiler/implementation/library_loader.dart

Issue 21074002: Remove support for missing part-of tag. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix extra tests. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/warnings.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/library_loader.dart
diff --git a/sdk/lib/_internal/compiler/implementation/library_loader.dart b/sdk/lib/_internal/compiler/implementation/library_loader.dart
index 0bcd1a51ca3f377c5f4de13601372de47740c680..95f91c853d699817486096901153aac926361025 100644
--- a/sdk/lib/_internal/compiler/implementation/library_loader.dart
+++ b/sdk/lib/_internal/compiler/implementation/library_loader.dart
@@ -368,17 +368,10 @@ class LibraryLoaderTask extends LibraryLoader {
compiler.withCurrentElement(unit, () {
compiler.scanner.scan(unit);
if (unit.partTag == null) {
- bool wasDiagnosticEmitted = false;
- compiler.withCurrentElement(library, () {
- wasDiagnosticEmitted =
- compiler.onDeprecatedFeature(part, 'missing part-of tag');
- });
- if (wasDiagnosticEmitted) {
- compiler.reportMessage(
- compiler.spanFromElement(unit),
- MessageKind.MISSING_PART_OF_TAG.error(),
- api.Diagnostic.INFO);
- }
+ compiler.reportMessage(
ahe 2013/08/06 14:22:06 compiler.reportError(unit, MessageKind.MISSING_PAR
Johnni Winther 2013/08/07 06:00:51 Done.
+ compiler.spanFromElement(unit),
+ MessageKind.MISSING_PART_OF_TAG.error(),
+ api.Diagnostic.ERROR);
}
});
}
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/warnings.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698