Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2107383003: ash/mus: Store the InterfaceRequest<>s directly in the vector. (Closed)

Created:
4 years, 5 months ago by sadrul
Modified:
4 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash/mus: Store the InterfaceRequest<>s directly in the vector. Instead of wrapping the InterfaceRequest<>s in a unique_ptr<> and storing that in a vector, just store the requests directly. BUG=none Committed: https://crrev.com/c36b54a49cfdd6df9fce8241134e4123b9b697f2 Cr-Commit-Position: refs/heads/master@{#403277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M ash/mus/window_manager_application.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/mus/window_manager_application.cc View 3 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sadrul
4 years, 5 months ago (2016-06-30 19:50:40 UTC) #2
James Cook
LGTM
4 years, 5 months ago (2016-06-30 19:58:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107383003/1
4 years, 5 months ago (2016-06-30 20:12:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 20:47:23 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 20:50:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c36b54a49cfdd6df9fce8241134e4123b9b697f2
Cr-Commit-Position: refs/heads/master@{#403277}

Powered by Google App Engine
This is Rietveld 408576698