Fix the flaky test KioskTest.LaunchAppUserCancel

chrome/browser/chromeos/login/existing_user_controller.cc

Index: chrome/browser/chromeos/login/existing_user_controller.cc
diff --git a/chrome/browser/chromeos/login/existing_user_controller.cc b/chrome/browser/chromeos/login/existing_user_controller.cc
index 455bd89f2152389bfe250d39bd4975d788ed67d8..e49ad9c29a6416b1175809bcb94fee03a20cc17d 100644
--- a/chrome/browser/chromeos/login/existing_user_controller.cc
+++ b/chrome/browser/chromeos/login/existing_user_controller.cc
@@ -262,10 +262,11 @@ void ExistingUserController::UpdateLoginDisplay(
   cros_settings_->GetBoolean(kAccountsPrefAllowGuest, &show_guest);
   show_users_on_signin |= !filtered_users.empty();
   show_guest &= !filtered_users.empty();
-  bool show_new_user = true;
+  bool allow_new_user = true;
+  cros_settings_->GetBoolean(kAccountsPrefAllowNewUser, &allow_new_user);

[afakhry, 2016/06/30 17:41:37]

This might have been a bug or intentionally missing?

[xiyuan, 2016/06/30 20:21:40]

kAccountsPrefAllowNewUser is handled as part of the whitelist checking.

https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/login/s...

|show_new_user| is actually not used today. It was there in old days when we
have a fake user pod for adding user.

I think it is okay to get rid of it and re-purpose it for allow new user.

   login_display_->set_parent_window(GetNativeWindow());
-  login_display_->Init(
-      filtered_users, show_guest, show_users_on_signin, show_new_user);
+  login_display_->Init(filtered_users, show_guest, show_users_on_signin,
+                       allow_new_user);
   host_->OnPreferencesChanged();
 }