Fix the flaky test KioskTest.LaunchAppUserCancel

Fix the flaky test KioskTest.LaunchAppUserCancel

BUG=624201
TEST=browser_tests --gtest_filter=KioskTest.LaunchAppUserCancel

Committed: https://crrev.com/5933575e915ee8002f604b7f8cdee2b544ea3a5f
Cr-Commit-Position: refs/heads/master@{#403455}

[afakhry, 2016-06-29 22:18:01]

afakhry@chromium.org changed reviewers:
+ xiyuan@chromium.org

[afakhry, 2016-06-29 22:18:02]

Xiyuan, please review.

[xiyuan, 2016-06-29 22:18:59]

lgtm

[afakhry, 2016-06-30 17:41:38]

The previous fix didn't work as it broke 4 other tests:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

Please take a look at this one.

https://codereview.chromium.org/2107353002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/existing_user_controller.cc (right):

https://codereview.chromium.org/2107353002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.cc:266:
cros_settings_->GetBoolean(kAccountsPrefAllowNewUser, &allow_new_user);
This might have been a bug or intentionally missing?

[xiyuan, 2016-06-30 20:21:40]

Thank you for helping on this.

https://codereview.chromium.org/2107353002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/existing_user_controller.cc (right):

https://codereview.chromium.org/2107353002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller.cc:266:
cros_settings_->GetBoolean(kAccountsPrefAllowNewUser, &allow_new_user);
On 2016/06/30 17:41:37, afakhry wrote:
> This might have been a bug or intentionally missing?

kAccountsPrefAllowNewUser is handled as part of the whitelist checking.

https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/login/s...

|show_new_user| is actually not used today. It was there in old days when we
have a fake user pod for adding user.

I think it is okay to get rid of it and re-purpose it for allow new user.

https://codereview.chromium.org/2107353002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right):

https://codereview.chromium.org/2107353002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:960:
(first_preference_changed && !IsSigninScreen(GetCurrentScreen()))) {
Can we get rid of |first_preference_changed| and use "ui_state_ ==
UI_STATE_UNKNOWN" ?

If that does not work, let's make first_preference_changed a member instead of
local static.

[afakhry, 2016-07-01 13:14:33]

https://codereview.chromium.org/2107353002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right):

https://codereview.chromium.org/2107353002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:960:
(first_preference_changed && !IsSigninScreen(GetCurrentScreen()))) {
On 2016/06/30 20:21:40, xiyuan wrote:
> Can we get rid of |first_preference_changed| and use "ui_state_ ==
> UI_STATE_UNKNOWN" ?
> 
> If that does not work, let's make first_preference_changed a member instead of
> local static.

Done.

[xiyuan, 2016-07-01 14:25:34]

LGTM!

[afakhry, 2016-07-01 14:41:33]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2016-07-01 14:41:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 14:45:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-01 14:45:54]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-01 14:47:48]

Description was changed from

==========
Fix the flaky test KioskTest.LaunchAppUserCancel

BUG=624201
TEST=browser_tests --gtest_filter=KioskTest.LaunchAppUserCancel
==========

to

==========
Fix the flaky test KioskTest.LaunchAppUserCancel

BUG=624201
TEST=browser_tests --gtest_filter=KioskTest.LaunchAppUserCancel

Committed: https://crrev.com/5933575e915ee8002f604b7f8cdee2b544ea3a5f
Cr-Commit-Position: refs/heads/master@{#403455}
==========

[commit-bot: I haz the power, 2016-07-01 14:47:49]

Patchset 4 (id:??) landed as
https://crrev.com/5933575e915ee8002f604b7f8cdee2b544ea3a5f
Cr-Commit-Position: refs/heads/master@{#403455}