Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: pkg/analysis_server/lib/src/status/get_handler.dart

Issue 2107313002: Make SDK contexts visible on status page (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/engine.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/status/get_handler.dart
diff --git a/pkg/analysis_server/lib/src/status/get_handler.dart b/pkg/analysis_server/lib/src/status/get_handler.dart
index 2983b7d9cb8301c9cd5cdf6331896914049488b4..a49310033489830d1cc569a2dbec99d91fafa7ba 100644
--- a/pkg/analysis_server/lib/src/status/get_handler.dart
+++ b/pkg/analysis_server/lib/src/status/get_handler.dart
@@ -1717,7 +1717,27 @@ class GetHandler {
buffer.write(' <small>[no .packages file]</small>');
}
});
- // TODO(brianwilkerson) Add items for the SDK contexts (currently only one).
+ buffer.write('</p>');
+ buffer.write('<p><b>SDK Contexts</b></p>');
+ buffer.write('<p>');
+ first = true;
+ List<String> descriptors = analysisServer.sdkManager.sdkDescriptors
+ .map((SdkDescription descriptor) => descriptor.toString())
+ .toList();
+ if (descriptors.isEmpty) {
+ buffer.write('none');
+ } else {
+ descriptors.sort();
+ for (String descriptor in descriptors) {
+ if (first) {
+ first = false;
+ } else {
+ buffer.write('<br>');
+ }
+ // TODO(brianwilkerson) Add a link to information about the contexts.
+ buffer.write(descriptor);
+ }
+ }
buffer.write('</p>');
int freq = AnalysisServer.performOperationDelayFrequency;
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/engine.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698